Fix plugin compatibility warning when plugins admin is disabled#24429
Open
predictor2718 wants to merge 1 commit intomatomo-org:5.x-devfrom
Open
Fix plugin compatibility warning when plugins admin is disabled#24429predictor2718 wants to merge 1 commit intomatomo-org:5.x-devfrom
predictor2718 wants to merge 1 commit intomatomo-org:5.x-devfrom
Conversation
predictor2718
force-pushed
the
fix/23941-plugin-admin-disabled-warning
branch
from
1751917 to
5888059
Compare
sgiehl
force-pushed
the
fix/23941-plugin-admin-disabled-warning
branch
from
5888059 to
675b5fb
Compare
Author
|
Could a maintainer please set the milestone to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
enable_plugins_admin = 0is configured, the warning about incompatible plugins still showed a link to the Manage Plugins page — which is inaccessible in that configuration.Changes
core/Plugin/ControllerAdmin.php: checkCorePluginsAdmin::isPluginsAdminEnabled()before rendering the Manage Plugins link; show alternative text if admin is disabledplugins/CoreAdminHome/lang/en.json: new translation keyInvalidPluginsAdminDisabledFixes #23941
Before Fix:
After Fix:
Checklist