Embedded graphs in reports render with raw metrics.

[nathangavin]

Description

Addresses #24273

When generating a report with embedded graphs in a language that uses different delimiters with numbers (e.g. '1.2' becomes '1,2'), the ImageGraph API was fetching metrics in the translated form, and using them to create the graphs to embed. Older PHP versions would implicitly handle these metrics (on PHP 7.2, '1,2' would be intepreted as 1), however newer PHP versions will hard fail on the ceil() method when passed a string.

This fix addresses this by first requesting raw metrics when generating the graph. This means that metrics should always be formatted in the standard style, which is intepreted by PHP type casting more consistently. Secondly, the method for processing ordinance values for the ImageGraph API has been hardened to always return a Float, which is what the graph generation code is expecting.

Since the raw metrics are only used to generate the graph shape (bar size, line shape etc), the end user should not be able to see any difference.

Checklist

• [✔] I have understood, reviewed, and tested all AI outputs before use
• [✔] All AI instructions respect security, IP, and privacy rules

Review

• Functional review done
• Potential edge cases thought about (behaviour of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
• Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
• Security review done
• Wording review done
• Code review done
• Tests were added if useful/possible
• Reviewed for breaking changes
• Developer changelog updated if needed
• New documentation added or existing documentation updated

[chippison]

A few simplfications and everythings all good!
👍

[chippison]

This can be replaced by:
After the preg_replace, the value can only be digits and dots, is_numeric does not add any value anymore. The function empty() also covers null and empty string

Suggested change

	if ($ordinateValue === null || $ordinateValue === '' || $ordinateValue === '.') {
	return 0.0;
	}
	return is_numeric($ordinateValue) ? (float) $ordinateValue : 0.0;
	if (empty($ordinateValue) || $ordinateValue === '.') {
	return 0.0;
	}
	return (float) $ordinateValue;

[nathangavin]

yep agreed, makes sense.

[chippison]

Can be simplified a bit more by:
is_numeric will cover both is_int and is_float
no need to add @ as you have force $ordinateValue to be a string

Suggested change

	if (is_int($ordinateValue) || is_float($ordinateValue)) {
	return (float) $ordinateValue;
	}
	$ordinateValue = @str_replace(',', '.', (string) $ordinateValue);
	if (is_numeric($ordinateValue)) {
	return (float) $ordinateValue;
	}
	$ordinateValue = str_replace(',', '.', (string) $ordinateValue);

[nathangavin]

same here, good suggestion.