Skip to content

Fix contrast in white-label header#24446

Merged
chippison merged 5 commits into5.x-devfrom
fix-white-label
Apr 29, 2026
Merged

Fix contrast in white-label header#24446
chippison merged 5 commits into5.x-devfrom
fix-white-label

Conversation

@tzi
Copy link
Copy Markdown
Contributor

@tzi tzi commented Apr 29, 2026

Description

Header background on login page

Previously, the header was not customized in the login page. It's fixed now.

Desktop and mobile menu

When a user set up a custom header font color, the menu could have a very low contrast.

Here, you can see the issue in action and the rendering after the fix. The fix do not provides a clear focus style, but it is at least readable.

what before after
customized
desktop 
Screenshot 2026-04-29 at 10 22 20 Screenshot 2026-04-29 at 10 50 37
customized
mobile
Screenshot 2026-04-29 at 10 22 27 Screenshot 2026-04-29 at 10 21 36

The rendering without any customization still looks fine.

what before after
default
desktop 
Screenshot 2026-04-29 at 10 23 18 Screenshot 2026-04-29 at 10 49 15
default
mobile
Screenshot 2026-04-29 at 10 23 13 Screenshot 2026-04-29 at 10 20 57

Dark mode is impacted, the focus styles changed a bit…

what before after
darkmode
desktop 
Screenshot 2026-04-29 at 10 36 18 Screenshot 2026-04-29 at 10 49 25
darkmode
+customized
Screenshot 2026-04-29 at 10 50 41

Checklist

  • [NA] I have understood, reviewed, and tested all AI outputs before use
  • [NA] All AI instructions respect security, IP, and privacy rules

Review

@tzi tzi added this to the 5.10.0 milestone Apr 29, 2026
@tzi tzi changed the title Fix white label Fix contrast for white label header Apr 29, 2026
@tzi tzi force-pushed the fix-white-label branch 2 times, most recently from 8faa2ff to c10dd39 Compare April 29, 2026 08:51
@tzi tzi added the Bug For errors / faults / flaws / inconsistencies etc. label Apr 29, 2026
@tzi tzi force-pushed the fix-white-label branch from 3188429 to 751b57a Compare April 29, 2026 14:36
@tzi tzi marked this pull request as ready for review April 29, 2026 15:56
@tzi tzi changed the title Fix contrast for white label header Fix contrast in white-label header Apr 29, 2026
sgiehl
sgiehl previously requested changes Apr 29, 2026
@tzi tzi force-pushed the fix-white-label branch from 751b57a to 178a822 Compare April 29, 2026 18:06
Comment thread plugins/CoreHome/tests/UI/expected-screenshots/WhatIsNew_menu.png
@tzi tzi mentioned this pull request Apr 29, 2026
10 tasks
@tzi tzi requested a review from sgiehl April 29, 2026 21:19
Copy link
Copy Markdown
Contributor

@chippison chippison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is all good and we will cleanup the screenshots and red bubble on a separate issue

@chippison chippison dismissed sgiehl’s stale review April 29, 2026 21:23

Issues noted and will be worked on spearate PR's

@chippison chippison merged commit f6b2de9 into 5.x-dev Apr 29, 2026
62 of 63 checks passed
@chippison chippison deleted the fix-white-label branch April 29, 2026 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug For errors / faults / flaws / inconsistencies etc.

Development

Successfully merging this pull request may close these issues.

3 participants