Skip to content

Fix search label contrast on dark mode#24448

Merged
sgiehl merged 2 commits into5.x-devfrom
fix-search-label-contrast
Apr 29, 2026
Merged

Fix search label contrast on dark mode#24448
sgiehl merged 2 commits into5.x-devfrom
fix-search-label-contrast

Conversation

@tzi
Copy link
Copy Markdown
Contributor

@tzi tzi commented Apr 29, 2026

Description

The search label is very light in light mode, but it is almost impossible to read in dark mode

before after
Screenshot 2026-04-29 at 11 19 49 Screenshot 2026-04-29 at 11 20 07
Screenshot 2026-04-29 at 11 19 38 Screenshot 2026-04-29 at 11 20 10

Checklist

  • [NA] I have understood, reviewed, and tested all AI outputs before use
  • [NA] All AI instructions respect security, IP, and privacy rules

Review

@tzi tzi added this to the 5.10.0 milestone Apr 29, 2026
@tzi tzi force-pushed the fix-search-label-contrast branch from 138125d to bddc564 Compare April 29, 2026 13:00
@tzi tzi force-pushed the fix-search-label-contrast branch from bddc564 to 7a05943 Compare April 29, 2026 13:30
@tzi tzi marked this pull request as ready for review April 29, 2026 15:38
@tzi tzi requested a review from a team April 29, 2026 15:39
@tzi tzi added c: Design / UI For issues that impact Matomo's user interface or the design overall. c: Accessibility When something is not usable for a certain group (eg missing contrast) or devices (eg smartphones). labels Apr 29, 2026
Copy link
Copy Markdown
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A PR for TagManager is missing. But core changes look fine.

@tzi
Copy link
Copy Markdown
Contributor Author

tzi commented Apr 29, 2026

Added here: matomo-org/tag-manager#1107

@sgiehl sgiehl merged commit 6cca9f0 into 5.x-dev Apr 29, 2026
70 of 72 checks passed
@sgiehl sgiehl deleted the fix-search-label-contrast branch April 29, 2026 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: Accessibility When something is not usable for a certain group (eg missing contrast) or devices (eg smartphones). c: Design / UI For issues that impact Matomo's user interface or the design overall.

Development

Successfully merging this pull request may close these issues.

2 participants