Added code to skip setting password confirmation requirement for non-ldap user#435
Open
AltamashShaikh wants to merge 1 commit into5.x-devfrom
Open
Added code to skip setting password confirmation requirement for non-ldap user#435AltamashShaikh wants to merge 1 commit into5.x-devfrom
AltamashShaikh wants to merge 1 commit into5.x-devfrom
Conversation
lachiebol
requested changes
Apr 29, 2026
Contributor
lachiebol
left a comment
There was a problem hiding this comment.
From codex, I had a bit of a look. Does this ldap user check need to be in those other methods?
• 1. Blocking: the branch only narrows the pre-check, not the actual bypass. The new observer in config/
config.php:19 makes Piwik::doesUserRequirePasswordConfirmation() return true for non-LDAP users,
which is the right direction for UI/API gating (/home/lachlan/matomo-code/matomo_5x-dev/core/
Piwik.php:296, /home/lachlan/matomo-code/matomo_5x-dev/core/Plugin/API.php:127). But LoginLdap still
auto-verifies the password for every user when enable_password_confirmation=0 in both
LoginLdap.php:331 and Controller.php:80, with no LDAP-user check. So a non-LDAP user who reaches the
confirmation flow can still bypass re-authentication entirely. For a security-sensitive path, that
means the branch only partially fixes the problem.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added code to skip setting password confirmation requirement for non-ldap user
Issue No
Steps to Replicate the Issue
Checklist