Upgrade dependencies to support php 8.5, #PG-5111#24
Closed
Upgrade dependencies to support php 8.5, #PG-5111#24
Conversation
Contributor
AltamashShaikh
left a comment
There was a problem hiding this comment.
@lachiebol Since now we have transpiled it, good to run the tests for min php version
- The committed dependency metadata still says otherwise. composer.lock and the vendored package manifests continue to declare lcobucci/jwt as PHP 8.2+ and lcobucci/clock as PHP 8.3+ (composer.lock:90,
composer.lock:157, vendor/prefixed/lcobucci/clock/composer.json:12, vendor/prefixed/lcobucci/jwt/composer.json:20). Even if the transpiled PHP files work, the shipped metadata is inconsistent and will confuse
maintainers and tooling.
The branch advertises PHP support that the shipped dependencies do not support. composer.json and plugin.json both lower the plugin floor to >=7.2.5 (composer.json:5, plugin.json:7), but the locked and vendored
packages require much newer PHP: lcobucci/jwt requires ~8.2 || ~8.3 || ~8.4 || ~8.5 (composer.lock:154, vendor/prefixed/lcobucci/jwt/composer.json:20) and lcobucci/clock requires ~8.3 || ~8.4 || ~8.5
(composer.lock:90, vendor/prefixed/lcobucci/clock/composer.json:12). This means the plugin can be installed or advertised as compatible on PHP versions where its bundled code is unsupported.
Contributor
|
@lachiebol I also see tests failing, did we scope it correctly ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Issue No
Resolves #21
Steps to Replicate the Issue
Checklist