Skip to content

Upgrade dependencies to support php 8.5, #PG-5111#24

Closed
lachiebol wants to merge 4 commits into5.x-devfrom
PG-5111-fix-dependencies
Closed

Upgrade dependencies to support php 8.5, #PG-5111#24
lachiebol wants to merge 4 commits into5.x-devfrom
PG-5111-fix-dependencies

Conversation

@lachiebol
Copy link
Copy Markdown
Contributor

@lachiebol lachiebol commented Apr 20, 2026

Description

Issue No

Resolves #21

Steps to Replicate the Issue

Checklist

  • [✔] Tested locally or on demo2/demo3?
  • [✔/✖/NA] New test case added/updated?
  • [✔/✖/NA] Are all newly added texts included via translation?
  • [✔/✖/NA] Are text sanitized properly? (Eg use of v-text v/s v-html for vue)
  • [✔] Version bumped?
  • [NA] I have understood, reviewed, and tested all AI outputs before use
  • [NA] All AI instructions respect security, IP, and privacy rules
  • [✔/✖/NA] Documentation updated?

@lachiebol lachiebol changed the title Upgrade dependencies to support php 8.4 Upgrade dependencies to support php 8.4, PG-5111-fix-dependencies Apr 20, 2026
@lachiebol lachiebol added the Needs Review For pull requests that need a code review. label Apr 20, 2026
@lachiebol lachiebol changed the title Upgrade dependencies to support php 8.4, PG-5111-fix-dependencies Upgrade dependencies to support php 8.4, #PG-5111 Apr 21, 2026
@lachiebol lachiebol changed the title Upgrade dependencies to support php 8.4, #PG-5111 Upgrade dependencies to support php 8.5, #PG-5111 Apr 21, 2026
Copy link
Copy Markdown
Contributor

@AltamashShaikh AltamashShaikh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lachiebol Since now we have transpiled it, good to run the tests for min php version

- The committed dependency metadata still says otherwise. composer.lock and the vendored package manifests continue to declare lcobucci/jwt as PHP 8.2+ and lcobucci/clock as PHP 8.3+ (composer.lock:90,
    composer.lock:157, vendor/prefixed/lcobucci/clock/composer.json:12, vendor/prefixed/lcobucci/jwt/composer.json:20). Even if the transpiled PHP files work, the shipped metadata is inconsistent and will confuse
    maintainers and tooling.


The branch advertises PHP support that the shipped dependencies do not support. composer.json and plugin.json both lower the plugin floor to >=7.2.5 (composer.json:5, plugin.json:7), but the locked and vendored
    packages require much newer PHP: lcobucci/jwt requires ~8.2 || ~8.3 || ~8.4 || ~8.5 (composer.lock:154, vendor/prefixed/lcobucci/jwt/composer.json:20) and lcobucci/clock requires ~8.3 || ~8.4 || ~8.5
    (composer.lock:90, vendor/prefixed/lcobucci/clock/composer.json:12). This means the plugin can be installed or advertised as compatible on PHP versions where its bundled code is unsupported.

@AltamashShaikh
Copy link
Copy Markdown
Contributor

@lachiebol I also see tests failing, did we scope it correctly ?

@lachiebol lachiebol closed this Apr 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs Review For pull requests that need a code review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Please update depencies to support active PHP versions

2 participants