Adding Matomo URL to email report#137
Merged
snake14 merged 1 commit intomatomo-org:5.x-devfrom Dec 18, 2024
Merged
Conversation
snake14
approved these changes
Dec 17, 2024
Contributor
snake14
left a comment
snake14
left a comment
There was a problem hiding this comment.
Looks good to me. I just had one optional comment.
Any concerns merging this @AltamashShaikh ?
Comment on lines
+45
to
+46
| $url = parse_url($matomoUrl); | ||
| $matomoHost = $url['host']; |
Contributor
There was a problem hiding this comment.
Maybe this would be a little cleaner?
Suggested change
| $url = parse_url($matomoUrl); | |
| $matomoHost = $url['host']; | |
| $matomoHost = parse_url($matomoUrl, PHP_URL_HOST); |
AltamashShaikh
approved these changes
Dec 18, 2024
Contributor
AltamashShaikh
left a comment
AltamashShaikh
left a comment
There was a problem hiding this comment.
Looks good to me 👍
Contributor
|
@snake14 let the tests run, if all good we can merge it 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
When you manage more than one Matomo instance, you would like to know from which instance you are getting email alert. This merge requests adds Matomo URL to the email report.
Fixes: #136
Review