Adds code to restrict token_auth post param#103
Open
AltamashShaikh wants to merge 2 commits intomasterfrom
Open
Adds code to restrict token_auth post param#103AltamashShaikh wants to merge 2 commits intomasterfrom
AltamashShaikh wants to merge 2 commits intomasterfrom
Conversation
sgiehl
requested changes
Apr 30, 2026
Comment on lines
+291
to
+292
| sanitizeTrackingOverrideParams($_POST); | ||
| $postBody = http_build_query($_POST); |
Member
There was a problem hiding this comment.
Technically I'm not sure if this might not have any side effects. file_get_contents("php://input") uses the real raw input, while http_build_query($_POST) sort of reconstructs it, while it may normalize ordering, repeated params, array syntax, and encoding details. I wonder if it might be safe to just go this path if at least one of the disallowed parameters was really discarded.
Member
There was a problem hiding this comment.
That one should be removed again
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds code to restrict token_auth post param
Checklist
Review