Copy CORS headers when substituting responses#178
Merged
Conversation
... otherwise the client won't be able to read the modified response.
andybalaam
approved these changes
May 20, 2025
richvdh
changed the title
Contributor
|
Uh oh, this didn't pass CI, can we please refrain from merging things that don't pass the CI? The failure isn't a fluke and it broke the CI for the Rust SDK as well. Not sure why, but blocking a request doesn't work after this PR anymore. Posted a PR to revert this here: #183 |
Member
Author
|
The CI seemed to be basically completely broken, tbh, for reasons I didn't really have the time/energy to investigate. |
Contributor
|
Well yes, this PR somehow broke request blocking which a bunch of tests depend on. |
Member
Author
|
Yes, but CI was failing on previous PRs too, so the CI appeared to be effectively useless. |
Contributor
|
Oh, that's an unfortunate series of failures. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... otherwise the client won't be able to read the modified response.