Skip to content

MatrixRTC: Implement expiry logic for CallMembership and additional test coverage#4587

Merged
hughns merged 13 commits intodevelopfrom
toger5/refactor-matrixrtcsession-part2-add-back-tests
Jan 7, 2025
Merged

MatrixRTC: Implement expiry logic for CallMembership and additional test coverage#4587
hughns merged 13 commits intodevelopfrom
toger5/refactor-matrixrtcsession-part2-add-back-tests

Conversation

@toger5
Copy link
Copy Markdown
Contributor

@toger5 toger5 commented Dec 16, 2024 •
edited by hughns
Loading

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • Sign-off given on the changes (see CONTRIBUTING.md).

@toger5
remove all legacy call related code and adjust tests.
05915fb 
We actually had a bit of tests just for legacy and not for session events. All those tests got ported over so we do not remove any tests.
@toger5 toger5 requested a review from a team as a code owner December 16, 2024 19:13
@toger5 toger5 requested review from hughns and robintown and removed request for a team December 16, 2024 19:13
@toger5 toger5 mentioned this pull request Dec 16, 2024
Merged
4 tasks
@toger5 toger5 force-pushed the toger5/refactor-matrixrtcsession-part1-legacy branch from 795a3cf to e8588e8 Compare December 16, 2024 19:21
@toger5 toger5 force-pushed the toger5/refactor-matrixrtcsession-part2-add-back-tests branch from 5d1df49 to 2a45f29 Compare December 16, 2024 19:42
@toger5 toger5 force-pushed the toger5/refactor-matrixrtcsession-part2-add-back-tests branch from 2a45f29 to 2fc5f94 Compare December 17, 2024 10:36
@toger5 toger5 force-pushed the toger5/refactor-matrixrtcsession-part2-add-back-tests branch from 2fc5f94 to b239510 Compare December 17, 2024 10:37
@toger5 toger5 force-pushed the toger5/refactor-matrixrtcsession-part2-add-back-tests branch from b239510 to f9847cc Compare December 17, 2024 10:38
@hughns
Copy link
Copy Markdown
Member

hughns commented Jan 6, 2025

Blocked on #4583

Base automatically changed from toger5/refactor-matrixrtcsession-part1-legacy to develop January 6, 2025 17:41
@toger5 toger5 requested a review from a team as a code owner January 6, 2025 17:41
@toger5 toger5 requested a review from florianduros January 6, 2025 17:41
@hughns hughns changed the title MatrixRTC: Add new tests for session type member events that before only existed for legacy member events MatrixRTC: Implement expiry logic for CallMembership and additional test coverage Jan 6, 2025
@hughns hughns removed the X-Blocked label Jan 6, 2025
@hughns hughns added this pull request to the merge queue Jan 6, 2025
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jan 6, 2025
@hughns hughns added this pull request to the merge queue Jan 7, 2025
Merged via the queue into develop with commit 6f743bf Jan 7, 2025
@hughns hughns deleted the toger5/refactor-matrixrtcsession-part2-add-back-tests branch January 7, 2025 10:30
@hughns hughns mentioned this pull request Jan 27, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hughns hughns hughns approved these changes

@robintown robintown Awaiting requested review from robintown robintown is a code owner automatically assigned from matrix-org/element-call-reviewers

@florianduros florianduros Awaiting requested review from florianduros florianduros was automatically assigned from matrix-org/element-web-reviewers

Assignees

No one assigned

Labels

T-Enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@toger5 @hughns
⚡