[WIP] Refactor matrixRTCSession Part3: MemberMachine#4592
Closed
[WIP] Refactor matrixRTCSession Part3: MemberMachine#4592
Conversation
We actually had a bit of tests just for legacy and not for session events. All those tests got ported over so we do not remove any tests.
… for legacy member events. This reverts commit 795a3cf.
toger5
changed the title
Base automatically changed from
toger5/refactor-matrixrtcsession-part2-add-back-tests
to
develop
January 7, 2025 10:30
Contributor
Author
|
Closing this in favor of: #4608 This still will be used as reference when we refactor the myMembershipManager |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Very WIP, mostly sharing to discuss the code.
Checklist
public/exportedsymbols have accurate TSDoc documentation.