MatrixRTC: MembershipManager test cases and deprecation of MatrixRTCSession.room#4713
Merged
MatrixRTC: MembershipManager test cases and deprecation of MatrixRTCSession.room#4713
Conversation
hughns
requested changes
Feb 17, 2025
Member
hughns
left a comment
hughns
left a comment
There was a problem hiding this comment.
Just a few quick things. I haven't looked at the main test cases yet.
toger5
force-pushed
the
hughns/membershipmanager-test-cases
branch
from
a2702a3 to
987863a
Compare
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Feb 17, 2025
Pulled out from #4713
toger5
force-pushed
the
hughns/membershipmanager-test-cases
branch
from
8926281 to
d9192f3
Compare
toger5
changed the title
toger5
force-pushed
the
hughns/membershipmanager-test-cases
branch
from
8788ce4 to
3d46d05
Compare
hughns
requested changes
Feb 19, 2025
hughns
changed the title
dbkr
approved these changes
Feb 26, 2025
Member
dbkr
left a comment
dbkr
left a comment
There was a problem hiding this comment.
Thanks for the fixes, looks good.
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
hughns
changed the title
Member
|
The latest commits add a deprecation, so I've updated the title, labels, description. As such, I'm re-submitting for review from Web Team. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of element-hq/element-call#2972.
This shouldn't introduce any behaviour changes, but refactor the tests to be based on the MembershipManager abstraction. It includes some tests which would fail on the current LegacyMembershipManager implementation which will be handled by a new implementation.
The field
MatrixRTCSession.roombecomes deprecated as theRoomshould be tracked by the client outside of theMatrixRTCSession.Checklist
public/exportedsymbols have accurate TSDoc documentation.