Rotate the current room key when we see a member leave#5231
Merged
Rotate the current room key when we see a member leave#5231
Conversation
kaylendog
commented
Mar 18, 2026
Signed-off-by: Skye Elliot <actuallyori@gmail.com>
kaylendog
force-pushed
the
kaylendog/msc4268/rotate-key
branch
from
700cfce to
89f05c9
Compare
Signed-off-by: Skye Elliot <actuallyori@gmail.com>
kaylendog
force-pushed
the
kaylendog/msc4268/rotate-key
branch
from
89f05c9 to
af43f6c
Compare
4 tasks
andybalaam
reviewed
Mar 19, 2026
Member
andybalaam
left a comment
andybalaam
left a comment
There was a problem hiding this comment.
Looks good to me - one question, and I would definitely like Rich to have a look too.
andybalaam
approved these changes
Mar 20, 2026
Member
andybalaam
left a comment
andybalaam
left a comment
There was a problem hiding this comment.
Yep, looks great. I feel like this would be easier to test with a real homeserver. Maybe this is one for complement-crypto, or maybe we can do that somewhere within rust-sdk?
Contributor
Author
|
I wrote a test in the Rust SDK for its analagous PR, which you can find here |
richvdh
requested changes
Mar 23, 2026
t3chguy
approved these changes
Mar 24, 2026
Co-authored-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Skye Elliot <actuallyori@gmail.com>
richvdh
reviewed
Mar 25, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This was referenced Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds logic to the
RustCrypto.onRoomMembershipevent handler that discards (and hence rotates) the current session whenever we see an eventleavemembership.Part of element-hq/element-meta#3078
Checklist
public/exportedsymbols have accurate TSDoc documentation.