This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Merged
Conversation
MidhunSureshR
added
the
T-Enhancement
- Adds id, ariaLabelledBy and role props to implement tab accessibility. - Adds hideHeaderButtons prop to hide header buttons (think back and close buttons). - Change confusing header rendering code: header is not rendered ONLY when no header is passed AND hideHeaderButtons is true.
Created a new function createSpaceScopeHeader which returns the component if the room is a space room. Previously this code was duplicated in every component that uses SpaceScopeHeader component.
Actually using the code from the last two commits
MidhunSureshR
force-pushed
the
midhun/add-tabs-to-rightpanel
branch
from
129a145 to
a8ead86
Compare
Member
Author
|
@richvdh : Hopefully it's a bit easier to review commit by commit now |
Member
|
@MidhunSureshR could you link to the designs please |
t3chguy
reviewed
Jul 9, 2024
Member
There was a problem hiding this comment.
Colour of Info should be darker here, and the weight of all the tab titles should be higher
|
Feedback:
|
Ignore this comment, everything LGTM |
americanrefugee
approved these changes
Jul 9, 2024
t3chguy
approved these changes
Jul 9, 2024
t3chguy
added
the
X-Release-Blocker
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For element-hq/element-web#26597
Design in https://www.figma.com/design/gpxHFDTNK796n84r1ZxYG2/Room-Header-%26-Details-(2024)?node-id=1-8700&t=SuUdpAsiC4vj94ea-0
Changes:
Introduces a new
RightPanelTabscomponent with the following tabs:RoomSummaryCardMemberListThreadPanelClicking on an item in the TAC will focus the
Threadstab instead of focusing the close button in the thread panel.The previous
RightPanelStore.showOrHidePanelis now renamed toRightPanelStore.showOrHidePhase.showOrHidePanelintroduces the following new behavior:Adds an info icon that opens the room summary panel.
Some changes to
BaseCard:id,ariaLabelledBy,role) for accessibility.hideHeaderButtonsprop to not show the back/close buttons.Cleanup the code for optional rendering of space headers by extracting the code into
createSpaceScopeHeader()