feat(base): Add automatic media cache cleanups to MediaService#4603
Merged
Hywan merged 11 commits intomatrix-org:mainfrom Feb 5, 2025
Merged
feat(base): Add automatic media cache cleanups to MediaService#4603Hywan merged 11 commits intomatrix-org:mainfrom
Hywan merged 11 commits intomatrix-org:mainfrom
Conversation
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
…y (de)serializing them Since it's a common occurrence, it will reduce duplication. Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
We want to be able to send it to a new task, so the easiest way is to be able to clone it. Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
…nt Clone We want to be able to send the store to a new task, so the easiest way is to be able to clone it. Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
For parity with tokio's JoinHandle. Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4603 +/- ##
==========================================
+ Coverage 85.70% 85.72% +0.01%
==========================================
Files 292 292
Lines 33406 33487 +81
==========================================
+ Hits 28632 28708 +76
- Misses 4774 4779 +5 ☔ View full report in Codecov by Sentry. |
Hywan
approved these changes
Feb 4, 2025
Member
Hywan
left a comment
Hywan
left a comment
There was a problem hiding this comment.
Well, I had a couple of feedback but they were all addressed by the original code. Nothing to say other than: well done! I'm excited to see this!
Member
|
Can you please resolve the conflict to unblock the merge please? |
Collaborator
Author
|
Done. |
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
Member
|
Thanks, you rocks 🤘 |
yostyle
pushed a commit
to tchapgouv/matrix-rust-sdk
that referenced
this pull request
Apr 4, 2025
feat(base): Add automatic media cache cleanups to MediaService
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #4571, this time we offer to run periodic automatic cleanups. This requires a few more bounds on the types to be able to send them into a new task.
This can be reviewed commit by commit.