Memoize the Oidc::account_management_url() method#4663
Merged
Conversation
poljar
force-pushed
the
poljar/cache-for-account-management-url
branch
from
20b2558 to
7f78661
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4663 +/- ##
=======================================
Coverage 85.78% 85.79%
=======================================
Files 292 293 +1
Lines 33729 33769 +40
=======================================
+ Hits 28936 28973 +37
- Misses 4793 4796 +3 ☔ View full report in Codecov by Sentry. |
poljar
force-pushed
the
poljar/cache-for-account-management-url
branch
from
7f78661 to
cef565c
Compare
bnjbvr
approved these changes
Feb 13, 2025
|
|
||
| /// Force the expiry of the given item, if it is present in the cache. | ||
| /// | ||
| /// This doesn't remove the item, it just marks it as expired. |
Contributor
There was a problem hiding this comment.
Why not remove it immediately? If it's expired, is there any point in keeping it in the mapping?
Contributor
Author
There was a problem hiding this comment.
That method is for testing purposes mostly, perhaps I should make itcfg(test).
It expires the item and then we check that a get() correctly removes it.
zecakeh
reviewed
Feb 13, 2025
zecakeh
reviewed
Feb 13, 2025
poljar
force-pushed
the
poljar/cache-for-account-management-url
branch
from
d114fee to
f59bdc4
Compare
poljar
force-pushed
the
poljar/cache-for-account-management-url
branch
from
f59bdc4 to
be6f567
Compare
This was referenced Feb 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will hopefully fix #4460.