Fix compilation of oauth under WASM and remove experimental-oidc feature#4830
Merged
stefanceriu merged 7 commits intomatrix-org:mainfrom Mar 24, 2025
Merged
Fix compilation of oauth under WASM and remove experimental-oidc feature#4830stefanceriu merged 7 commits intomatrix-org:mainfrom
oauth under WASM and remove experimental-oidc feature#4830stefanceriu merged 7 commits intomatrix-org:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4830 +/- ##
==========================================
- Coverage 86.50% 86.49% -0.01%
==========================================
Files 297 297
Lines 34600 34600
==========================================
- Hits 29930 29927 -3
- Misses 4670 4673 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zecakeh
force-pushed
the
oauth-wasm32
branch
3 times, most recently
from
94fe083 to
9214135
Compare
stefanceriu
approved these changes
Mar 24, 2025
Member
stefanceriu
left a comment
stefanceriu
left a comment
There was a problem hiding this comment.
Beautiful, thank you very much Kevin! 🙏
Member
|
I don't know why it's complaining about conflicts, a rebase looks fine on my side ¯_(ツ)_/¯ |
It usually won't be possible to write data to a file. Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
They almost all require a mock server. Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
Now that is compiles under WASM and that the API was cleaned up, it should be okay. Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
Since it requires the crypto store. Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
Collaborator
Author
|
Sorry, I just rebased on main because GitHub was telling me there was a conflict. I didn't get any conflict while rebasing though. |
Contributor
|
Wow, congratulations Kevin on getting this through the finish line, amazing work as usual! 🥳 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Can be reviewed commit by commit:
experimental-oidcfeature. Now that it compiles under WASM and that the API was cleaned up, it should be stable enough.Closes #4593.