feat(sdk): Add Client::logout() to log out regardless of the auth API#4886
Merged
poljar merged 3 commits intomatrix-org:mainfrom Apr 4, 2025
Merged
feat(sdk): Add Client::logout() to log out regardless of the auth API#4886poljar merged 3 commits intomatrix-org:mainfrom
Client::logout() to log out regardless of the auth API#4886poljar merged 3 commits intomatrix-org:mainfrom
Conversation
It simplifies code for users, and avoids to have to match on `AuthApi`, which is a non-exhaustive enum. Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4886 +/- ##
==========================================
+ Coverage 85.82% 85.85% +0.03%
==========================================
Files 299 299
Lines 35233 35245 +12
==========================================
+ Hits 30239 30261 +22
+ Misses 4994 4984 -10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
poljar
approved these changes
Apr 4, 2025
Contributor
poljar
left a comment
poljar
left a comment
There was a problem hiding this comment.
That's indeed a nice simplification.
zecakeh
added a commit
to zecakeh/matrix-rust-sdk
that referenced
this pull request
Apr 4, 2025
Introduced by merging matrix-org#4886 and matrix-org#4887 around the same time. Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It simplifies code for users, and avoids to have to match on
AuthApi, which is a non-exhaustive enum.