Merged
Conversation
…t` to keep in line with the UI crate types
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4902 +/- ##
=======================================
Coverage 85.69% 85.69%
=======================================
Files 309 309
Lines 35398 35398
=======================================
+ Hits 30333 30336 +3
+ Misses 5065 5062 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
stefanceriu
added a commit
to matrix-org/complement-crypto
that referenced
this pull request
Apr 8, 2025
stefanceriu
added a commit
to matrix-org/complement-crypto
that referenced
this pull request
Apr 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch introduces an intermediary MsgLike Content and Type on the FFI layer and brings the timeline items in line with the ones from the UI crate.
This is the last step in the timeline item structure factoring, following #4839, #4853 and #4860
Best reviewed commit by commit.