refactor(sdk): Remove SlidingSyncRoom 🎉 #5047
Merged
Hywan merged 10 commits intomatrix-org:mainfrom May 19, 2025
Merged
Conversation
Hywan
added a commit
to Hywan/matrix-rust-sdk
that referenced
this pull request
May 16, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5047 +/- ##
==========================================
- Coverage 85.85% 85.82% -0.04%
==========================================
Files 325 324 -1
Lines 35936 35874 -62
==========================================
- Hits 30854 30790 -64
- Misses 5082 5084 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Hywan
added a commit
to Hywan/matrix-rust-sdk
that referenced
this pull request
May 16, 2025
Hywan
force-pushed
the
fix-sdk-sliding-sync-room
branch
from
b18bf0e to
e368dbb
Compare
This patch removes the `SlidingSync::get_room` method. The goal is to remove `SlidingSyncRoom`.
This patch removes `SlidingSync::get_number_of_rooms`. The goal is to remove `SlidingSyncRoom`.
This patch removes `SlidingSync::get_rooms` and `get_all_rooms`. The goal is to remove `SlidingSyncRoom`.
This patch stops maintaining/updating `SlidingSync::rooms`. The goal is to remove `SlidingSyncRoom`.
This patch removes the `SlidingSync::rooms` field. A cascade of removal happens, and many part of the code is simplified. The most notable is `FrozenSlidingSync`.
This patch FINALLY removes `SlidingSyncRoom`, youhou!
This patch removes `FrozenSlidingSync`. Its unique field is supposed to be stored in the crypto store.
Hywan
force-pushed
the
fix-sdk-sliding-sync-room
branch
2 times, most recently
from
7acda1f to
89cd768
Compare
Hywan
force-pushed
the
fix-sdk-sliding-sync-room
branch
from
89cd768 to
4370d02
Compare
Hywan
changed the title
SlidingSyncRoomSlidingSyncRoom 🎉
stefanceriu
approved these changes
May 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Et in Arcadia ego (Nicolas Poussin)
Et in Arcadia ego means “Me (the Death) are even in Arcadia (the country of delights)”, or “Me (who is the Death) has even lived in Arcadia”. It can be understood as “Even in an ideal country, no one escapes the fate of mortals”. It includes
SlidingSyncRoom.It's my great honor to submit this patch that closes #3079 by removing the entire
SlidingSyncRoomtype. This was a long-standing tech debt that has been introduced at the beginning of the sliding sync experiment. Sadly, this type has spread in the SDK, and it took a bit of time to get rid of it. Now, it's different. Now the time has come to burn it.SlidingSyncRoomtech debt #3079