feat(sdk,ui): Unset the unread flag when sending unthreaded receipts#5055
Merged
Hywan merged 12 commits intomatrix-org:mainfrom May 21, 2025
Merged
feat(sdk,ui): Unset the unread flag when sending unthreaded receipts#5055Hywan merged 12 commits intomatrix-org:mainfrom
Hywan merged 12 commits intomatrix-org:mainfrom
Conversation
zecakeh
added a commit
to zecakeh/matrix-rust-sdk
that referenced
this pull request
May 19, 2025
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5055 +/- ##
==========================================
+ Coverage 85.83% 85.84% +0.01%
==========================================
Files 325 325
Lines 35924 35954 +30
==========================================
+ Hits 30836 30866 +30
Misses 5088 5088 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Hywan
requested changes
May 19, 2025
Member
Hywan
left a comment
Hywan
left a comment
There was a problem hiding this comment.
Thanks for the PR. Apart from the minor feedback, we are good!
Comment on lines
+609
to
+615
| if !receipts.is_empty() { | ||
| self.room().send_multiple_receipts(receipts).await?; | ||
| } else if self.room().is_marked_unread() { | ||
| self.room().set_unread_flag(false).await?; | ||
| } |
Member
There was a problem hiding this comment.
Can we add let room = self.room(); to avoid calling self.room() multiple time please?
Comment on lines
+635
to
+637
| if self.room().is_marked_unread() { | ||
| // Unset the read marker. | ||
| self.room().set_unread_flag(false).await?; |
Member
There was a problem hiding this comment.
Can we add let room = self.room(); to avoid calling self.room() multiple time please?
Collaborator
Author
There was a problem hiding this comment.
With the removal of the condition, there is only one call here now.
bnjbvr
reviewed
May 19, 2025
Comment on lines
+611
to
+612
| } else if self.room().is_marked_unread() { | ||
| self.room().set_unread_flag(false).await?; |
Contributor
There was a problem hiding this comment.
Instead of specializing each call site of Room::set_unread_flag(), consider making Room::set_unread_flag a no-op (aka return early without sending the request) if !self.is_marked_unread()?
…Room Updates the unread flag or the room in `Room::send_single_receipt()` and `Room::send_multiple_receipts()` if the room is marked as unread and the receipts are unthreaded. Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
…imeline Updates the unread flag or the room in `Timeline::send_single_receipt()` and `Timeline::send_multiple_receipts()` if the room is marked as unread and the receipts are unthreaded. Updates it also in `Timeline::mark_as_read()`, even if there is no latest event ID. Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
…g already has the wanted value Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
…ry time Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
zecakeh
force-pushed
the
auto-unset-unread
branch
from
6ce071d to
380f78d
Compare
Collaborator
Author
|
Rebased on main to solve conflicts. |
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
Hywan
pushed a commit
that referenced
this pull request
May 21, 2025
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows to follow these recommendations from the spec automatically:
Note that there was a function in the bindings doing a similar thing that was removed in #3119, but it doesn't seem that it was necessary to fix the bug that it was trying to fix.