Skip to content

feat(threads): implement msc4308 companion endpoint#5590

Merged
bnjbvr merged 3 commits intomainfrom
bnjbvr/msc4308-companion-endpoint
Aug 29, 2025
Merged

feat(threads): implement msc4308 companion endpoint#5590
bnjbvr merged 3 commits intomainfrom
bnjbvr/msc4308-companion-endpoint

Conversation

@bnjbvr
Copy link
Copy Markdown
Contributor

@bnjbvr bnjbvr commented Aug 27, 2025

This bumps Ruma (to an unstable branch, because we need ruma/ruma#2200 for tests, duh), which brings us a few documented test fixes.

In addition to this, this implements the support for the companion endpoint of MSC4308, which allows to back-paginate thread subscriptions, if the sync response contained only a small subset of the entire change set.

Part of #5038.

@bnjbvr bnjbvr requested a review from a team as a code owner August 27, 2025 16:04
@bnjbvr bnjbvr requested review from Hywan and removed request for a team August 27, 2025 16:04
@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 27, 2025

Codecov Report

❌ Patch coverage is 98.33333% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 88.62%. Comparing base (99af951) to head (0e74ffd).
⚠️ Report is 3 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
crates/matrix-sdk/src/client/mod.rs 88.88% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5590   +/-   ##
=======================================
  Coverage   88.61%   88.62%           
=======================================
  Files         341      341           
  Lines       95413    95466   +53     
  Branches    95413    95466   +53     
=======================================
+ Hits        84550    84602   +52     
  Misses       6646     6646           
- Partials     4217     4218    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Aug 27, 2025

CodSpeed Performance Report

Merging #5590 will not alter performance

Comparing bnjbvr/msc4308-companion-endpoint (0e74ffd) with main (99af951)

Summary

✅ 49 untouched benchmarks

Copy link
Copy Markdown
Member

@Hywan Hywan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good, thanks for the small patches!

Comment thread crates/matrix-sdk/CHANGELOG.md Outdated
@bnjbvr bnjbvr force-pushed the bnjbvr/msc4308-companion-endpoint branch from 93111ff to 504bcb6 Compare August 29, 2025 09:10
bnjbvr added 3 commits August 29, 2025 11:12
We get test fixes for free, thanks to the new push rules semantics
implemented in Ruma \o/
@bnjbvr bnjbvr force-pushed the bnjbvr/msc4308-companion-endpoint branch from 504bcb6 to 0e74ffd Compare August 29, 2025 09:12
@bnjbvr bnjbvr enabled auto-merge (rebase) August 29, 2025 09:12
@bnjbvr bnjbvr merged commit 3ba31d1 into main Aug 29, 2025
53 checks passed
@bnjbvr bnjbvr deleted the bnjbvr/msc4308-companion-endpoint branch August 29, 2025 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants