feat: Download room keys from backup before building key bundle.#6017
Merged
feat: Download room keys from backup before building key bundle.#6017
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6017 +/- ##
==========================================
- Coverage 88.94% 88.93% -0.01%
==========================================
Files 357 357
Lines 99178 99198 +20
Branches 99178 99198 +20
==========================================
+ Hits 88210 88223 +13
- Misses 6987 6992 +5
- Partials 3981 3983 +2 ☔ View full report in Codecov by Sentry. |
kaylendog
force-pushed
the
kaylendog/history-sharing/backup-download
branch
2 times, most recently
from
92a1733 to
1436a75
Compare
Signed-off-by: Skye Elliot <actuallyori@gmail.com>
kaylendog
force-pushed
the
kaylendog/history-sharing/backup-download
branch
from
1436a75 to
afe30c3
Compare
- Splits `test_secret_gossip_after_interactive_verification ` into a helper method. Signed-off-by: Skye Elliot <actuallyori@gmail.com>
kaylendog
force-pushed
the
kaylendog/history-sharing/backup-download
branch
2 times, most recently
from
afe30c3 to
831ab6d
Compare
kaylendog
requested review from
andybalaam and
stefanceriu
and removed request for
a team
andybalaam
approved these changes
Jan 13, 2026
Member
andybalaam
left a comment
andybalaam
left a comment
There was a problem hiding this comment.
Looks great. Couple of tiny comments.
Before we merge I'd like to see how this is rendered in clients. Presumably this download could be really slow so they will need to display a spinner or equivalent.
Contributor
Author
We do indeed, tested and works! |
kaylendog
added a commit
that referenced
this pull request
Jan 26, 2026
…DB. (#6044) While #6017 is mostly functional, there are two issues: - I did not process `changes.room_key_bundles_fully_downloaded` in `matrix-sdk-sqlite`, meaning any updates made via `Changes` would not be persisted; - I used a non-encrypting `JsValue` serialisation for the same field in `matrix-sdk-indexeddb`, which causes errors when passed to the decryption-enabled deserializer. Solutions: - Process the aforementioned changes such that keys are added to SQLite; - Use a non-encrypting deserialiser, since this is effectively a hash-set, and the contents aren't sensitive. Signed-off-by: Skye Elliot <actuallyori@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
share_room_historyto fetch all room keys from backup if this has not done before.Signed-off-by: Skye Elliot actuallyori@gmail.com