feat(qr-login): add additional QRCodeGrantLoginError enum values#6141
Merged
poljar merged 3 commits intomatrix-org:mainfrom Feb 27, 2026
Merged
feat(qr-login): add additional QRCodeGrantLoginError enum values#6141poljar merged 3 commits intomatrix-org:mainfrom
poljar merged 3 commits intomatrix-org:mainfrom
Conversation
43f986b to
a9787e9
Compare
a9787e9 to
c76d52e
Compare
6 tasks
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #6141 +/- ##
==========================================
+ Coverage 89.88% 89.93% +0.04%
==========================================
Files 367 367
Lines 101140 101957 +817
Branches 101140 101957 +817
==========================================
+ Hits 90905 91690 +785
- Misses 6690 6716 +26
- Partials 3545 3551 +6 ☔ View full report in Codecov by Sentry. |
ed264a0 to
2180251
Compare
1 task
hughns
commented
Feb 17, 2026
2180251 to
68974d6
Compare
poljar
requested changes
Feb 26, 2026
Contributor
poljar
left a comment
There was a problem hiding this comment.
Sorry for the delay, I forgot to press the correct button.
The PR looks good we just need to move the changelog entries to the correct place.
poljar
approved these changes
Feb 27, 2026
Contributor
|
Oh, seems that there are some conflicts now, could you resolve them? |
d65e27b to
64c1153
Compare
64c1153 to
c1ea0ea
Compare
Member
Author
|
I missed one of the changelog entries. I'll fix that now. |
…nQrGrantLoginError::UnableToCreateDevice
3fd5648 to
7d44ea8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On top of #6178
This adds additional
QRCodeGrantLoginErrorenum values in the SDK crate and additionalHumanQrGrantLoginErrorenum values in the FFI crate.Most of the new values are assigned from what previous went to
Unknownenum values.The is one bugfix for where
::DeviceIDAlreadyInUsewas erroneously being returned when the actually the device was not returned by the homeserver. This is now mapped to::DeviceNotFoundvalues.Signed-off-by: