Skip to content

feat(qr-login): add additional QRCodeGrantLoginError enum values#6141

Merged
poljar merged 3 commits intomatrix-org:mainfrom
hughns:hughns/qr-code-grant-login-errors
Feb 27, 2026
Merged

feat(qr-login): add additional QRCodeGrantLoginError enum values#6141
poljar merged 3 commits intomatrix-org:mainfrom
hughns:hughns/qr-code-grant-login-errors

Conversation

@hughns
Copy link
Copy Markdown
Member

@hughns hughns commented Feb 9, 2026

On top of #6178

This adds additional QRCodeGrantLoginError enum values in the SDK crate and additional HumanQrGrantLoginError enum values in the FFI crate.

Most of the new values are assigned from what previous went to Unknown enum values.

The is one bugfix for where ::DeviceIDAlreadyInUse was erroneously being returned when the actually the device was not returned by the homeserver. This is now mapped to ::DeviceNotFound values.

  • Public API changes documented in changelogs (optional)

Signed-off-by:

@hughns hughns force-pushed the hughns/qr-code-grant-login-errors branch 3 times, most recently from 43f986b to a9787e9 Compare February 9, 2026 12:02
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Feb 9, 2026

Merging this PR will not alter performance

✅ 50 untouched benchmarks


Comparing hughns:hughns/qr-code-grant-login-errors (7d44ea8) with main (bbdfe7b)

Open in CodSpeed

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 9, 2026

Codecov Report

❌ Patch coverage is 96.63963% with 29 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.93%. Comparing base (bbdfe7b) to head (7d44ea8).
⚠️ Report is 3 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...atrix-sdk/src/authentication/oauth/qrcode/grant.rs 96.74% 18 Missing and 10 partials ⚠️
.../matrix-sdk/src/authentication/oauth/qrcode/mod.rs 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6141      +/-   ##
==========================================
+ Coverage   89.88%   89.93%   +0.04%     
==========================================
  Files         367      367              
  Lines      101140   101957     +817     
  Branches   101140   101957     +817     
==========================================
+ Hits        90905    91690     +785     
- Misses       6690     6716      +26     
- Partials     3545     3551       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hughns hughns force-pushed the hughns/qr-code-grant-login-errors branch 3 times, most recently from ed264a0 to 2180251 Compare February 17, 2026 11:12
@hughns hughns marked this pull request as ready for review February 17, 2026 11:13
@hughns hughns requested a review from a team as a code owner February 17, 2026 11:13
@hughns hughns requested review from poljar and stefanceriu and removed request for a team February 17, 2026 11:13
Comment thread crates/matrix-sdk/src/authentication/oauth/qrcode/grant.rs Outdated
@hughns hughns force-pushed the hughns/qr-code-grant-login-errors branch from 2180251 to 68974d6 Compare February 17, 2026 13:27
Copy link
Copy Markdown
Contributor

@poljar poljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay, I forgot to press the correct button.

The PR looks good we just need to move the changelog entries to the correct place.

Comment thread crates/matrix-sdk/CHANGELOG.md Outdated
Comment thread crates/matrix-sdk/CHANGELOG.md Outdated
@hughns hughns requested a review from poljar February 27, 2026 10:05
@poljar
Copy link
Copy Markdown
Contributor

poljar commented Feb 27, 2026

Oh, seems that there are some conflicts now, could you resolve them?

@hughns hughns force-pushed the hughns/qr-code-grant-login-errors branch from d65e27b to 64c1153 Compare February 27, 2026 10:06
@hughns hughns force-pushed the hughns/qr-code-grant-login-errors branch from 64c1153 to c1ea0ea Compare February 27, 2026 10:08
@hughns
Copy link
Copy Markdown
Member Author

hughns commented Feb 27, 2026

I missed one of the changelog entries. I'll fix that now.

@hughns hughns force-pushed the hughns/qr-code-grant-login-errors branch from 3fd5648 to 7d44ea8 Compare February 27, 2026 10:13
@poljar poljar merged commit 7da0d90 into matrix-org:main Feb 27, 2026
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants