feat(sdk): Only share history if room history visibility is shared#6275
Merged
feat(sdk): Only share history if room history visibility is shared#6275
Conversation
Signed-off-by: Skye Elliot <actuallyori@gmail.com>
This commit additionally flips the order of a few assertions to meet developer expectations, i.e. errors are reported as diffs from expected. Signed-off-by: Skye Elliot <actuallyori@gmail.com>
Signed-off-by: Skye Elliot <actuallyori@gmail.com>
kaylendog
force-pushed
the
kaylendog/history-sharing/respect-visibility
branch
from
7bbdca7 to
d58873f
Compare
kaylendog
commented
Mar 11, 2026
2 tasks
4 tasks
This isn't strictly necessary, but the lack of these events was causing spurious CI timeouts when tested with the logic that assumed a stricter history visibility than the spec required.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6275 +/- ##
==========================================
+ Coverage 89.91% 89.93% +0.01%
==========================================
Files 372 372
Lines 102538 102538
Branches 102538 102538
==========================================
+ Hits 92199 92215 +16
+ Misses 6785 6771 -14
+ Partials 3554 3552 -2 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves the case where Alice and Bob share the keys to history unexpectedly by only sharing key bundles if the current room history is
sharedorworld_readable.Part of element-hq/element-meta#3101, which includes a full scenario this PR combats.
CHANGELOG.mdfiles.Signed-off-by: Skye Elliot actuallyori@gmail.com