Skip to content

Use a property to define JsonLibrary #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DMRobertson merged 5 commits into from
Feb 15, 2023
Merged

Use a property to define JsonLibrary #57

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
20a7e94
Use a property to define `Jsonlibrary`
Feb 15, 2023
7def2cb
Okay fine, coverage
Feb 15, 2023
c3ef1fc
Fix the JsonLibrary protocol
Feb 15, 2023
9370d26
Test under mypy 1.0
Feb 15, 2023
e3c4f60
Include mypy in default `tox` jobs
Feb 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/canonicaljson/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,10 @@ def __call__(self, *args: Any, **kwargs: Any) -> "Encoder":
pass


class JsonLibrary(Protocol):
JSONEncoder: Encoder
class JsonLibrary(Protocol): # pragma: no cover
@property
def JSONEncoder(self) -> Encoder:
pass


# Declare these in the module scope, but they get configured in
Expand Down
⚡