Skip to content

'ModuleApi' object has no attribute 'defer_to_threadpool' on upload/fetch with Synapse 1.122+ #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Umer481 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

'ModuleApi' object has no attribute 'defer_to_threadpool' on upload/fetch with Synapse 1.122+ #145

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions s3_storage_provider.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
from twisted.internet import defer, reactor
from twisted.python.failure import Failure
from twisted.python.threadpool import ThreadPool
from twisted.internet.threads import deferToThreadPool

from synapse.logging.context import make_deferred_yieldable
from synapse.module_api import ModuleApi, run_in_background
Expand Down Expand Up @@ -123,7 +124,8 @@ def _get_s3_client(self):
async def store_file(self, path, file_info):
"""See StorageProvider.store_file"""

return await self._module_api.defer_to_threadpool(
return await defer_to_threadpool(
reactor,
self._s3_pool,
self._get_s3_client().upload_file,
Filename=os.path.join(self.cache_directory, path),
Expand All @@ -144,7 +146,8 @@ async def fetch(self, path, file_info):
# coroutine returned by `defer_to_threadpool` is used, and therefore
# actually run.
run_in_background(
self._module_api.defer_to_threadpool,
deferToThreadPool,
reactor,
self._s3_pool,
s3_download_task,
self._get_s3_client(),
Expand Down
Loading
⚡