Fix "LoggingContext must be given either a name or a parent context" error#74
Closed
kunalchhabra37 wants to merge 1 commit intomatrix-org:mainfrom
Closed
Conversation
Fixed matrix-org#56 Error: LoggingContext must be given either a name or a parent context by adding LoggingContext() and logger.info() with parent context in LoggingContext() at line 269 - 271
clokep
changed the title
richvdh
requested changes
Apr 20, 2022
Comment on lines
+269
to
+271
| parent_logcontext = current_context() | ||
| with LoggingContext(parent_context=parent_logcontext): | ||
| logger.info("Responder For S3") |
Member
There was a problem hiding this comment.
what makes you believe this will fix the problem? I don't think it will.
Author
There was a problem hiding this comment.
I thought the parent context would solve the issue
Member
|
Superseded by #134 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #56
LoggingContext must be given either a name or a parent contextby addingLoggingContext()andlogger.info()with parent context inLoggingContext()at line 269 - 271