This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Do not call setup_background_tasks twice in tests.#16150
Merged
Conversation
anoadragon453
approved these changes
Aug 21, 2023
Member
anoadragon453
left a comment
anoadragon453
left a comment
There was a problem hiding this comment.
Seems reasonable. Presumably setup_background_tasks should only get run if you're the worker configured to run background tasks.
Member
Author
Pretty much, yes. 👍 |
Member
Author
|
This is hitting a complement flake, but changes unittest only code so I'm going to force-merge. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This gets called anyway via
hs.setup():synapse/synapse/server.py
Lines 346 to 347 in 358896e
This is important in that
hs.setup()has an extra if-statement which only runs this code if the worker is running background tasks, instead of unconditionally.Spun out of #16066.