This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Run the AS senders as background processes#4189
Merged
Conversation
This should fix some "Starting db connection from sentinel context" warnings, and will mean we get metrics for these processes.
Member
Author
Codecov Report
@@ Coverage Diff @@
## develop #4189 +/- ##
===========================================
+ Coverage 66.65% 73.55% +6.89%
===========================================
Files 299 299
Lines 29798 29808 +10
Branches 4871 4872 +1
===========================================
+ Hits 19863 21926 +2063
+ Misses 8501 6455 -2046
+ Partials 1434 1427 -7
Continue to review full report at Codecov.
|
Member
Author
|
yay, the test failures went away. |
Member
Author
|
[I'm not entirely sure why codecov thinks I've changed 119 files] |
erikjohnston
approved these changes
Dec 4, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix some "Starting db connection from sentinel context" warnings, and will mean we get metrics for these processes.