Fix incorrect logcontexts after a Deferred was cancelled

[richvdh]

... mostly because I wanted to check it did the right thing with logcontexts.

[erikjohnston]

👍

[erikjohnston]

Although the new test has failed on one of the runs...

[richvdh]

it's found a bug in an old version of twisted, I think...

[codecov-io]

Codecov Report

Merging #4407 into develop will increase coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #4407      +/-   ##
===========================================
+ Coverage    73.65%   73.68%   +0.02%     
===========================================
  Files          300      300              
  Lines        29815    29818       +3     
  Branches      4897     4898       +1     
===========================================
+ Hits         21961    21971      +10     
+ Misses        6412     6406       -6     
+ Partials      1442     1441       -1

Impacted Files	Coverage Δ
synapse/python_dependencies.py	45.83% <ø> (ø)	⬆️
synapse/util/async_helpers.py	91.44% <ø> (+2.13%)	⬆️
synapse/handlers/device.py	79.68% <0%> (-0.97%)	⬇️
synapse/config/key.py	67.64% <0%> (ø)	⬆️
synapse/util/logcontext.py	89.47% <0%> (+0.43%)	⬆️
synapse/util/file_consumer.py	82.45% <0%> (+1.75%)	⬆️
synapse/storage/background_updates.py	95.8% <0%> (+2.79%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f1a6a4...89d4c38. Read the comment docs.

[richvdh]

@erikjohnston ptal

[erikjohnston]

I assume the "fix" here is the bump of twisted version?

[richvdh]

yes.