Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Improve type checking in replication.tcp.Stream #7291

Merged
richvdh merged 8 commits into from
Apr 17, 2020
Merged

Improve type checking in replication.tcp.Stream #7291

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
4aa105c
fix type annotation for db_query_to_update_function
richvdh Apr 16, 2020
42691a0
Redefine StreamRow as the thing passed into parse_row()
richvdh Apr 16, 2020
f613429
Fix the return types for get_updates, etc
richvdh Apr 16, 2020
57873ad
Add an UpdateFunction type
richvdh Apr 16, 2020
868761c
changelog
richvdh Apr 16, 2020
e9df138
Introduce a StreamUpdateResult type
richvdh Apr 16, 2020
f7018e8
Pass callbacks into Stream constructor
richvdh Apr 16, 2020
abbc141
fix a few typos
richvdh Apr 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/7291.misc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Improve typing annotations in `synapse.replication.tcp.streams.Stream`.
5 changes: 1 addition & 4 deletions synapse/replication/tcp/streams/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,6 @@
update_function: The function that returns a list of updates between two tokens
"""

from typing import Dict, Type

from synapse.replication.tcp.streams._base import (
AccountDataStream,
BackfillStream,
Expand Down Expand Up @@ -67,8 +65,7 @@
GroupServerStream,
UserSignatureStream,
)
} # type: Dict[str, Type[Stream]]

}

__all__ = [
"STREAMS_MAP",
Expand Down
Loading
⚡