Skip to content

Upgrade to Node 24#22

Merged
saturninoabril merged 1 commit intomattermost:masterfrom
ggrossetie:21-node24
Apr 28, 2026
Merged

Upgrade to Node 24#22
saturninoabril merged 1 commit intomattermost:masterfrom
ggrossetie:21-node24

Conversation

@ggrossetie
Copy link
Copy Markdown
Contributor

@ggrossetie ggrossetie commented Mar 17, 2026

Summary

Upgrade to Node.js 24:

  • updated .nvmrc, action.yml, and package.json

Ticket Link

Fixes #21

Summary by CodeRabbit

  • Chores
    • Updated minimum Node.js version requirement from 20 to 24. All runtime and configuration specifications have been updated and aligned accordingly to support this new version. Users will need to have Node.js version 24 or higher installed to run and use this project effectively. This change ensures improved compatibility and better overall performance.

@ggrossetie ggrossetie requested a review from a team as a code owner March 17, 2026 09:18
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 17, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 96c97d56-b741-48b3-a08d-4e66b3073182

📥 Commits

Reviewing files that changed from the base of the PR and between d317dae and 75d54ba.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (3)
  • .nvmrc
  • action.yml
  • package.json

📝 Walkthrough

Walkthrough

Node.js runtime version is upgraded from 20 to 24 across three configuration files (.nvmrc, action.yml, and package.json) to address GitHub Actions deprecation of Node.js 20, ensuring compatibility with the updated runtime requirements.

Changes

Cohort / File(s) Summary
Node.js Version Upgrade
.nvmrc, action.yml, package.json
Updated Node.js version from 20 to 24 across all configuration files to align with GitHub Actions deprecation of Node.js 20.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The pull request title directly and concisely describes the main change: upgrading Node.js version from 20 to 24 across configuration files.
Linked Issues check ✅ Passed The pull request successfully addresses issue #21 by upgrading Node.js from version 20 to 24 in .nvmrc, action.yml, and package.json as required.
Out of Scope Changes check ✅ Passed All changes in the pull request are directly scoped to the Node.js upgrade objective; no unrelated modifications are present.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

Migrating from UI to YAML configuration.

Use the @coderabbitai configuration command in a PR comment to get a dump of all your UI settings in YAML format. You can then edit this YAML file and upload it to the root of your repository to configure CodeRabbit programmatically.

@mattermost-build
Copy link
Copy Markdown

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

@ggrossetie
Copy link
Copy Markdown
Contributor Author

Hey @toninis could you please review this PR? Thanks 🙌🏻

@ggrossetie
Copy link
Copy Markdown
Contributor Author

Thanks Antonis!

For reference, the "GitHub Actions Test" workflow is failing because the input MATTERMOST_WEBHOOK_URL is not specified in:

with:
MATTERMOST_WEBHOOK_URL: ${{ secrets.TEST_WEBHOOK_DELIVERY }}
TEXT: |
This is a TEXT message from ${{ github.repository }}.
[Pipeline](${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}) was completed :white_check_mark:
MATTERMOST_USERNAME: CI
MATTERMOST_ICON_URL: https://cdn3.iconfinder.com/data/icons/system-basic-vol-4-1/20/icon-note-attention-alt3-512.png

Having said that, this error is probably not related to my changes.

Copy link
Copy Markdown
Contributor

@saturninoabril saturninoabril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ggrossetie!

@saturninoabril saturninoabril merged commit ae31bb6 into mattermost:master Apr 28, 2026
3 of 4 checks passed
@ggrossetie ggrossetie deleted the 21-node24 branch April 28, 2026 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Node.js 20 actions are deprecated

5 participants