Skip to content

🐛 Fixed usage of plural in game_not_started page#528

Merged
mawoka-myblock merged 1 commit intomawoka-myblock:masterfrom
Proxyfil:fix/player-plural-typo
Apr 7, 2026
Merged

🐛 Fixed usage of plural in game_not_started page#528
mawoka-myblock merged 1 commit intomawoka-myblock:masterfrom
Proxyfil:fix/player-plural-typo

Conversation

@Proxyfil
Copy link
Copy Markdown
Contributor

@Proxyfil Proxyfil commented Apr 6, 2026

🎩 What? Why?

This PR changes the behaviour of the page game_not_started for the admin to actually update text when there is 0, 1 or multiple players.

The previous code was not using this, and thus, was never displaying the plural when needed.
Now for 0 or 1 it will be "player" and for more it will be "players", it should also be accurate in every translations because the text key was already in here.

I suggest now in another PR to fix the mistranslation (like in english "are waiting" for not plural or in french "joueurs sont en")

📌 Related Issues

No issue seen up to this day

Testing

Start a quiz, join with one user you will see "1 player are waiting", join with another one you will see "2 players are waiting"

📋 Checklist

⚠️ No tests suites for now ⚠️
🚨 Please review the guidelines for contributing to this repository.

  • CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to the overall architecture.

📷 Screenshots

image image

♥️ Thank you!

@mawoka-myblock mawoka-myblock merged commit 48dda62 into mawoka-myblock:master Apr 7, 2026
4 of 5 checks passed
@mawoka-myblock
Copy link
Copy Markdown
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants