🐛 Fixed usage of plural in game_not_started page#528
Merged
mawoka-myblock merged 1 commit intomawoka-myblock:masterfrom Apr 7, 2026
Merged
🐛 Fixed usage of plural in game_not_started page#528mawoka-myblock merged 1 commit intomawoka-myblock:masterfrom
mawoka-myblock merged 1 commit intomawoka-myblock:masterfrom
Conversation
mawoka-myblock
approved these changes
Apr 7, 2026
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
This PR changes the behaviour of the page game_not_started for the admin to actually update text when there is 0, 1 or multiple players.
The previous code was not using this, and thus, was never displaying the plural when needed.
Now for 0 or 1 it will be "player" and for more it will be "players", it should also be accurate in every translations because the text key was already in here.
I suggest now in another PR to fix the mistranslation (like in english "are waiting" for not plural or in french "joueurs sont en")
📌 Related Issues
No issue seen up to this day
Testing
Start a quiz, join with one user you will see "1 player are waiting", join with another one you will see "2 players are waiting"
📋 Checklist
🚨 Please review the guidelines for contributing to this repository.
CONSIDER adding a unit test if your PR resolves an issue.DO make sure tests pass.DO add CHANGELOG upgrade notes if required.AVOID breaking the continuous integration build.📷 Screenshots