Improve Intl.DurationFormat.format examples#28708
Merged
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
|
Preview URLs (comment last updated: 2023-08-28 13:45:03) |
Josh-Cena
reviewed
Aug 23, 2023
Josh-Cena
reviewed
Aug 23, 2023
Josh-Cena
requested changes
Aug 23, 2023
Member
Josh-Cena
left a comment
Josh-Cena
left a comment
There was a problem hiding this comment.
Hi @ben-allen thanks for the PR, but as a convention for Intl docs, the format pages are usually brief, and information about constructor options are included in the constructor page.
ben-allen
force-pushed
the
update-intl-durationformat-format-method
branch
from
1716a59 to
6373c5d
Compare
…anges related to fractionalDigits option
ben-allen
force-pushed
the
update-intl-durationformat-format-method
branch
from
6373c5d to
cbce13f
Compare
Contributor
Author
|
Updated to remove most of the examples, redundant explanations, and => in comments |
Josh-Cena
reviewed
Aug 23, 2023
Comment on lines
-47
to
-53
| // With style set to "long" | ||
| new Intl.DurationFormat("en", { style: "long" }).format(duration); | ||
| // "1 year, 2 months, 3 weeks, 3 days, 4 hours, 5 minutes, 6 seconds, 7 milliseconds, 8 microseconds, 9 nanoseconds" | ||
|
|
||
| // With style set to "narrow" | ||
| new Intl.DurationFormat("en", { style: "narrow" }).format(duration); | ||
| // "1y 2mo 3w 3d 4h 5m 6s 7ms 8μs 9ns" |
Member
There was a problem hiding this comment.
Curious why these are removed?
Josh-Cena
reviewed
Aug 23, 2023
Josh-Cena
reviewed
Aug 27, 2023
Member
Josh-Cena
left a comment
Josh-Cena
left a comment
There was a problem hiding this comment.
@ben-allen One remaining question (#28708 (comment)) and then we can merge this. I think it's valuable to have comparisons of different styles under the en locale.
Josh-Cena
changed the title
…ionformat/format/index.md Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Josh-Cena
approved these changes
Aug 28, 2023
Member
Josh-Cena
left a comment
Josh-Cena
left a comment
There was a problem hiding this comment.
LGTM. Thanks for the update!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…normative changes related to fractionalDigits option, clarify usage in general
Description
Motivation
Recent normative changes have altered the behaviour of `fractionalDigits. Intl.DurationFormat.format() now defaults to displaying however many digits are necessary to display all components, rather than defaulting to 0 fractional digits displayed.
Additional details
Related issues and pull requests
Relates to tc39/proposal-intl-duration-format#150