Skip to content

Absolute path to the @mdx-js/tag#234

Closed
jeetiss wants to merge 3 commits intomdx-js:masterfrom
jeetiss:absolute-path
Closed

Absolute path to the @mdx-js/tag#234
jeetiss wants to merge 3 commits intomdx-js:masterfrom
jeetiss:absolute-path

Conversation

@jeetiss
Copy link
Copy Markdown
Contributor

@jeetiss jeetiss commented Aug 23, 2018

The @mdx-js/tag dependency is not resolving if loader used with such builders as razzle, next etc.
I've added the absolutePath option to loader to make it able to resolve @mdx-js/tag in this case.

@vercel
Copy link
Copy Markdown

vercel Bot commented Aug 23, 2018

This pull request is automatically deployed with Now.

To access deployments, click Details below or on the icon next to each push.

@timneutkens
Copy link
Copy Markdown
Member

It works fine with Next.js though. Maybe razzle doesn't add the extra node_modules directory to the resolve key in webpack.

@jeetiss
Copy link
Copy Markdown
Contributor Author

jeetiss commented Aug 25, 2018

@timneutkens yep :(
can you review my pr to the jaredpalmer/razzle#732?

@jeetiss
Copy link
Copy Markdown
Contributor Author

jeetiss commented Aug 26, 2018

fix this in jaredpalmer/razzle#732

@jeetiss jeetiss closed this Aug 26, 2018
@jeetiss jeetiss deleted the absolute-path branch August 26, 2018 05:21
@timneutkens
Copy link
Copy Markdown
Member

👍 great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants