chore(js-sdk): add methods to manage promotion codes#14850
Open
asgerjensen wants to merge 2 commits intomedusajs:developfrom
Open
chore(js-sdk): add methods to manage promotion codes#14850asgerjensen wants to merge 2 commits intomedusajs:developfrom
asgerjensen wants to merge 2 commits intomedusajs:developfrom
Conversation
🦋 Changeset detectedLatest commit: b2ad5c7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 77 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@asgerjensen is attempting to deploy a commit to the medusajs Team on Vercel. A member of the Team first needs to authorize it. |
e83757d to
e2ea5b6
Compare
2991ba3 to
640bf71
Compare
640bf71 to
c12cf1f
Compare
|
Thank you for your contribution! After reviewing this PR, we need a few things addressed before we can move forward: Required changes:
Once these are addressed, another review will be triggered automatically. Thanks again! |
cbeccf7 to
fa52f99
Compare
fa52f99 to
b2ad5c7
Compare
Contributor
Author
|
@medusajs-bot review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
What — What changes are introduced in this PR?
Added functions on
storeclient to allow adding and removing promotion codes.Why — Why are these changes relevant or necessary?
The functionality is present in the /store api, but not reflected in the javascript client.
It /might/ have been possible before, by using the general
updatefunction, but it didn't give a clean way to deal with removals. As the API already exposes the functions, they may as well be made available to the javascript client.How — How have these changes been implemented?
Added to store client
Testing — How have these changes been tested, or how can the reviewer test the feature?
Built and included in demo repo, to verify typing and functionalty.
Examples
Provide examples or code snippets that demonstrate how this feature works, or how it can be used in practice.
This helps with documentation and ensures maintainers can quickly understand and verify the change.
Checklist
Please ensure the following before requesting a review:
yarn changesetand follow the promptsAdditional Context
Add any additional context, related issues, or references that might help the reviewer understand this PR.
Closes #15068