Fix product list crash with orphaned sales channel references

[moktamd]

Fixes #14945

Summary

What — Filters out null/orphaned sales channel entries in the product list table and product detail views.

Why — When a sales channel is deleted without cleaning up the product-to-sales-channel join table, the API returns null entries in product.sales_channels. The dashboard crashes with TypeError: Cannot read properties of null (reading 'name') when rendering these entries.

How — Replaced unguarded .map() calls with a type-safe filter predicate that narrows (SalesChannelDTO | null)[] to SalesChannelDTO[] before accessing .name or .id. Applied in both SalesChannelsCell (product list table) and ProductSalesChannelSection (product detail page).

Testing — To reproduce:

1. Create a product and assign it to a sales channel
2. Delete the sales channel directly from the database (or via API) without removing the join-table entry
3. Navigate to the product list — the page crashes
4. With this fix, the product list renders normally, skipping the orphaned channel references. Tooltip counts and "available in X of Y" text reflect only valid channels.

---

Checklist

• Added a changeset (yarn changeset — @medusajs/dashboard patch)
• Verified locally that the product list and detail views render without crash
• Linked related issue (Admin UI: Product list crashes with TypeError when product has orphaned sales channel reference #14945)

---

Note

Low Risk
Low-risk UI robustness change that filters out null sales channel entries to prevent runtime crashes when orphaned associations are returned by the API.

Overview
Prevents product list/detail rendering crashes when product.sales_channels contains orphaned null entries by filtering them out with type-guard predicates before mapping/printing channel name/id.

Adds a patch changeset for @medusajs/dashboard to release the fix.

^{Reviewed by Cursor Bugbot for commit 5d71df8. Bugbot is set up for automated code reviews on this repo. Configure here.}

[changeset-bot]

🦋 Changeset detected

Latest commit: 5d71df8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 77 packages

Name	Type
@medusajs/dashboard	Patch
@medusajs/admin-bundler	Patch
@medusajs/medusa	Patch
@medusajs/test-utils	Patch
@medusajs/medusa-oas-cli	Patch
integration-tests-http	Patch
@medusajs/analytics	Patch
@medusajs/api-key	Patch
@medusajs/auth	Patch
@medusajs/caching	Patch
@medusajs/cart	Patch
@medusajs/currency	Patch
@medusajs/customer	Patch
@medusajs/file	Patch
@medusajs/fulfillment	Patch
@medusajs/index	Patch
@medusajs/inventory	Patch
@medusajs/link-modules	Patch
@medusajs/locking	Patch
@medusajs/notification	Patch
@medusajs/order	Patch
@medusajs/payment	Patch
@medusajs/pricing	Patch
@medusajs/product	Patch
@medusajs/promotion	Patch
@medusajs/rbac	Patch
@medusajs/region	Patch
@medusajs/sales-channel	Patch
@medusajs/settings	Patch
@medusajs/stock-location	Patch
@medusajs/store	Patch
@medusajs/tax	Patch
@medusajs/translation	Patch
@medusajs/user	Patch
@medusajs/workflow-engine-inmemory	Patch
@medusajs/workflow-engine-redis	Patch
@medusajs/draft-order	Patch
@medusajs/oas-github-ci	Patch
@medusajs/cache-inmemory	Patch
@medusajs/cache-redis	Patch
@medusajs/event-bus-local	Patch
@medusajs/event-bus-redis	Patch
@medusajs/analytics-local	Patch
@medusajs/analytics-posthog	Patch
@medusajs/auth-emailpass	Patch
@medusajs/auth-github	Patch
@medusajs/auth-google	Patch
@medusajs/caching-redis	Patch
@medusajs/file-local	Patch
@medusajs/file-s3	Patch
@medusajs/fulfillment-manual	Patch
@medusajs/locking-postgres	Patch
@medusajs/locking-redis	Patch
@medusajs/notification-local	Patch
@medusajs/notification-sendgrid	Patch
@medusajs/payment-stripe	Patch
@medusajs/core-flows	Patch
@medusajs/framework	Patch
@medusajs/js-sdk	Patch
@medusajs/modules-sdk	Patch
@medusajs/orchestration	Patch
@medusajs/types	Patch
@medusajs/utils	Patch
@medusajs/workflows-sdk	Patch
@medusajs/http-types-generator	Patch
@medusajs/cli	Patch
@medusajs/deps	Patch
@medusajs/telemetry	Patch
@medusajs/admin-sdk	Patch
@medusajs/admin-shared	Patch
@medusajs/admin-vite-plugin	Patch
@medusajs/icons	Patch
@medusajs/toolbox	Patch
@medusajs/ui-preset	Patch
create-medusa-app	Patch
medusa-dev-cli	Patch
@medusajs/ui	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[vercel]

@moktamd is attempting to deploy a commit to the medusajs Team on Vercel.

A member of the Team first needs to authorize it.

[medusa-os-bot]

Thank you for your contribution!

After reviewing this PR, we need a few things addressed before we can move forward:

Required changes:

• Add a changeset — run yarn changeset and select @medusajs/dashboard as a patch. The message must follow the format: fix(@medusajs/dashboard): short description
• Fill in the PR description using our pull request template. The Testing section is missing — please describe how the reviewer can reproduce the crash and verify the fix (e.g., steps to create an orphaned sales channel reference and confirm the product list no longer crashes).

Notes:

• filter(Boolean) is not a type-safe predicate in TypeScript — it won't narrow (SalesChannelDTO | null)[] to SalesChannelDTO[]. If you're adding null-filtering, consider a type guard instead:

.filter((sc): sc is SalesChannelDTO => sc !== null && sc !== undefined)

This ensures downstream .name accesses are type-safe after filtering.

• The fix correctly addresses the UI crash, but the root cause is that the API returns null elements in product.sales_channels for orphaned join-table rows. It may be worth a follow-up issue on the backend side.

[moktamd]

Thanks for the review — addressed everything:

• Replaced filter(Boolean) with proper type guard predicates ((sc): sc is SalesChannelDTO => sc != null and (sc): sc is HttpTypes.AdminProductSalesChannel => sc != null)
• Changeset already included with the correct format: fix(@medusajs/dashboard): handle null sales channel entries in product list and detail views
• Rebased onto latest develop to resolve conflicts
• Testing section was already in the PR description

Agreed on the backend root cause — happy to open a follow-up issue for cleaning up orphaned join-table rows on sales channel deletion if that'd be useful.