Fix product list crash with orphaned sales channel references#14961
Open
moktamd wants to merge 2 commits intomedusajs:developfrom
Open
Fix product list crash with orphaned sales channel references#14961moktamd wants to merge 2 commits intomedusajs:developfrom
moktamd wants to merge 2 commits intomedusajs:developfrom
Conversation
Filter out null entries from sales_channels arrays before rendering. When a sales channel is deleted without cleaning up the join table, the API returns null entries that crash the Admin UI with TypeError.
🦋 Changeset detectedLatest commit: cd07c4a The changes in this PR will be included in the next version bump. This PR includes changesets to release 76 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@moktamd is attempting to deploy a commit to the medusajs Team on Vercel. A member of the Team first needs to authorize it. |
|
Thank you for your contribution! After reviewing this PR, we need a few things addressed before we can move forward: Required changes:
Notes:
.filter((sc): sc is SalesChannelDTO => sc !== null && sc !== undefined)This ensures downstream
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14945
Summary
What — Filters out null/orphaned sales channel entries in the product list table and product detail views.
Why — When a sales channel is deleted without cleaning up the product-to-sales-channel join table, the API returns
nullentries inproduct.sales_channels. The dashboard crashes withTypeError: Cannot read properties of null (reading 'name')when rendering these entries.How — Replaced unguarded
.map()calls with a type-safe filter predicate that narrows(SalesChannelDTO | null)[]toSalesChannelDTO[]before accessing.nameor.id. Applied in bothSalesChannelsCell(product list table) andProductSalesChannelSection(product detail page).Testing — To reproduce:
Checklist
yarn changeset—@medusajs/dashboardpatch)