fix(medusa): prevent plugin:db:generate crash when model files export enums#15083
Closed
ashif323 wants to merge 1 commit intomedusajs:developfrom
Closed
fix(medusa): prevent plugin:db:generate crash when model files export enums#15083ashif323 wants to merge 1 commit intomedusajs:developfrom
ashif323 wants to merge 1 commit intomedusajs:developfrom
Conversation
🦋 Changeset detectedLatest commit: 84c712a The changes in this PR will be included in the next version bump. This PR includes changesets to release 77 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@ashif323 is attempting to deploy a commit to the medusajs Team on Vercel. A member of the Team first needs to authorize it. |
… enums - Add test coverage for enum exports alongside entities - Add fixture plugin with enum + entity model - Closes medusajs#15077
ashif323
force-pushed
the
fix/plugin-db-generate-enum-crash
branch
from
0bc0995 to
84c712a
Compare
4 tasks
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Prevent
plugin:db:generatefrom crashing when model files exportTypeScript enums alongside MikroORM entities.
Why
MetadataStorage.getMetadataFromDecorator()returns truthy for anythingwith a
.nameproperty — which compiled TypeScript enums have — so enumsget misidentified as database entities, causing MikroORM to crash during
migration generation.
How
Replace the
MetadataStoragecheck withtypeof potentialEntity === "function"in
getEntitiesForModule(). Class constructors are functions; enum objectsare not. This aligns with the same pattern already used in
load-internal.ts.Changes
packages/medusa/src/commands/plugin/db/generate.tsplugins-1-with-enumwith enum and entity exportsCloses #15077