fix(medusa): prevent plugin:db:generate crash when model files export enums

.changeset/cyan-mice-kick.md

@@ -0,0 +1,5 @@
+---
+"@medusajs/medusa": patch
+---
+
+fix(medusa): prevent plugin:db:generate crash when model files export enums - adds test coverage

packages/medusa/src/commands/plugin/db/generate.ts

@@ -77,7 +77,7 @@ async function getEntitiesForModule(path: string) {
       (potentialEntity) => {
         return (
           DmlEntity.isDmlEntity(potentialEntity) ||
-          !!MetadataStorage.getMetadataFromDecorator(potentialEntity as any)
+          typeof potentialEntity === "function"
         )
       }
     )

packages/medusa/src/commands/plugin/db/integration-tests/__fixtures__/plugins-1-with-enum/src/modules/module-1/index.ts

@@ -0,0 +1,4 @@
+import { MedusaService, Module } from "@medusajs/framework/utils"
+export default Module("module1_with_enum", {
+  service: class Module1Service extends MedusaService({}) {},
+})

packages/medusa/src/commands/plugin/db/integration-tests/__fixtures__/plugins-1-with-enum/src/modules/module-1/models/module-model-1.ts

@@ -0,0 +1,14 @@
+import { model } from "@medusajs/framework/utils"
+
+// This enum export previously caused plugin:db:generate to crash
+export enum MyStatus {
+  ACTIVE = "active",
+  INACTIVE = "inactive",
+}
+
+const model1 = model.define("module_model_1_with_enum", {
+  id: model.id().primaryKey(),
+  name: model.text(),
+})
+
+export default model1

packages/medusa/src/commands/plugin/db/integration-tests/__tests__/plugin-generate.spec.ts

@@ -28,6 +28,19 @@ describe("plugin-generate", () => {
       )
     )
     await module1.remove("migrations")
+
+    const module1WithEnum = new FileSystem(
+      join(
+        __dirname,
+        "..",
+        "__fixtures__",
+        "plugins-1-with-enum",
+        "src",
+        "modules",
+        "module-1"
+      )
+    )
+    await module1WithEnum.remove("migrations")
   })
 
   describe("main function", () => {
@@ -89,5 +102,21 @@ describe("plugin-generate", () => {
 
       expect(process.exit).toHaveBeenCalledWith(1)
     })
+    it("should successfully generate migrations when model files export enums alongside entities", async () => {
+      await main({
+        directory: join(__dirname, "..", "__fixtures__", "plugins-1-with-enum"),
+      })
+      expect(logger.info).toHaveBeenNthCalledWith(1, "Generating migrations...")
+      expect(logger.info).toHaveBeenNthCalledWith(
+        2,
+        "Generating migrations for module module1_with_enum..."
+      )
+      expect(logger.info).toHaveBeenNthCalledWith(
+        3,
+        expect.stringContaining("Migration created")
+      )
+      expect(logger.info).toHaveBeenNthCalledWith(4, "Migrations generated")
+      expect(process.exit).toHaveBeenCalledWith()
+    })
   })
 })