Skip to content

chore(types): change payment provider types to interfaces#11597

Merged
shahednasser merged 2 commits intodevelopfrom
chore/payment-types-to-interfaces
Feb 25, 2025
Merged

chore(types): change payment provider types to interfaces#11597
shahednasser merged 2 commits intodevelopfrom
chore/payment-types-to-interfaces

Conversation

@shahednasser
Copy link
Copy Markdown
Member

@shahednasser shahednasser commented Feb 25, 2025

Since most payment types, such as CapturePaymentInput are just equal to PaymentProviderInput, the generated documentation uses the PaymentProviderInputtype instead of the CapturePaymentInput. This can cause some confusion as seen in issue #11590

To resolve this, we can convert those types to interfaces, which retains the types in the generated documentation.

Other: remove duplicate inventory type

@shahednasser shahednasser requested a review from a team as a code owner February 25, 2025 12:03
@vercel
Copy link
Copy Markdown

vercel bot commented Feb 25, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 25, 2025 0:24am
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Feb 25, 2025 0:24am
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Feb 25, 2025 0:24am
docs-ui ⬜️ Ignored (Inspect) Visit Preview Feb 25, 2025 0:24am
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Feb 25, 2025 0:24am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Feb 25, 2025 0:24am
resources-docs ⬜️ Ignored (Inspect) Visit Preview Feb 25, 2025 0:24am

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Feb 25, 2025

🦋 Changeset detected

Latest commit: eb09671

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 65 packages
Name Type
@medusajs/types Patch
integration-tests-http Patch
@medusajs/medusa Patch
@medusajs/test-utils Patch
@medusajs/api-key Patch
@medusajs/auth Patch
@medusajs/cache-inmemory Patch
@medusajs/cache-redis Patch
@medusajs/cart Patch
@medusajs/currency Patch
@medusajs/customer Patch
@medusajs/event-bus-local Patch
@medusajs/event-bus-redis Patch
@medusajs/file Patch
@medusajs/fulfillment Patch
@medusajs/index Patch
@medusajs/inventory Patch
@medusajs/link-modules Patch
@medusajs/locking Patch
@medusajs/notification Patch
@medusajs/order Patch
@medusajs/payment Patch
@medusajs/pricing Patch
@medusajs/product Patch
@medusajs/promotion Patch
@medusajs/region Patch
@medusajs/sales-channel Patch
@medusajs/stock-location Patch
@medusajs/store Patch
@medusajs/tax Patch
@medusajs/user Patch
@medusajs/workflow-engine-inmemory Patch
@medusajs/workflow-engine-redis Patch
@medusajs/auth-emailpass Patch
@medusajs/auth-github Patch
@medusajs/auth-google Patch
@medusajs/file-local Patch
@medusajs/file-s3 Patch
@medusajs/fulfillment-manual Patch
@medusajs/locking-postgres Patch
@medusajs/locking-redis Patch
@medusajs/notification-local Patch
@medusajs/notification-sendgrid Patch
@medusajs/payment-stripe Patch
@medusajs/core-flows Patch
@medusajs/framework Patch
@medusajs/js-sdk Patch
@medusajs/modules-sdk Patch
@medusajs/orchestration Patch
@medusajs/utils Patch
@medusajs/workflows-sdk Patch
@medusajs/cli Patch
@medusajs/medusa-oas-cli Patch
@medusajs/oas-github-ci Patch
@medusajs/telemetry Patch
@medusajs/admin-bundler Patch
@medusajs/admin-sdk Patch
@medusajs/admin-shared Patch
@medusajs/admin-vite-plugin Patch
@medusajs/dashboard Patch
@medusajs/icons Patch
@medusajs/toolbox Patch
@medusajs/ui-preset Patch
create-medusa-app Patch
medusa-dev-cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@shahednasser shahednasser merged commit 698a520 into develop Feb 25, 2025
23 checks passed
@shahednasser shahednasser deleted the chore/payment-types-to-interfaces branch February 25, 2025 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants