Move Order Complete Emit on Cart Complete later in the flow#13630
Closed
vethan wants to merge 2 commits intomedusajs:developfrom
Closed
Move Order Complete Emit on Cart Complete later in the flow#13630vethan wants to merge 2 commits intomedusajs:developfrom
vethan wants to merge 2 commits intomedusajs:developfrom
Conversation
…f the cart-complete is rolled back due to payment failure or any other issue occuring later in the workflow
🦋 Changeset detectedLatest commit: e46d204 The changes in this PR will be included in the next version bump. This PR includes changesets to release 72 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@vethan is attempting to deploy a commit to the medusajs Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
|
hey @vethan, I am curious to understand the issue you are facing because the events are not emitted, they are stored in the event group and will only be released once the workflow is finished 🤔 same goes with failed and reverted workflows, we do not emit the event group |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Emit the order placed event later in the flow, so it is not emitted if the cart-complete is rolled back due to payment failure or any other issue occurring later in the workflow
Note
Emit
OrderWorkflowEvents.PLACEDafter order creation (post-payment) instead of during the earlier parallel steps, preventing emission when the workflow reverts.emitEventStepforOrderWorkflowEvents.PLACEDfrom the earlyparallelize(...)block to afterorderCreatedhook (post payment authorization/transactions).Written by Cursor Bugbot for commit e46d204. This will update automatically on new commits. Configure here.