Skip to content

feat(product): build variant images when retrieving product#13731

Merged
kodiakhq[bot] merged 6 commits intodevelopfrom
feat/scoped-variant-images--product-fetch
Oct 28, 2025
Merged

feat(product): build variant images when retrieving product#13731
kodiakhq[bot] merged 6 commits intodevelopfrom
feat/scoped-variant-images--product-fetch

Conversation

@fPolic
Copy link
Copy Markdown
Contributor

@fPolic fPolic commented Oct 10, 2025

What

  • build variant images when retrieving product

@fPolic fPolic requested a review from a team as a code owner October 10, 2025 15:26
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Oct 10, 2025

🦋 Changeset detected

Latest commit: f1f3dd0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 74 packages
Name Type
@medusajs/product Patch
@medusajs/medusa Patch
integration-tests-http Patch
@medusajs/test-utils Patch
@medusajs/medusa-oas-cli Patch
@medusajs/analytics Patch
@medusajs/api-key Patch
@medusajs/auth Patch
@medusajs/caching Patch
@medusajs/cart Patch
@medusajs/currency Patch
@medusajs/customer Patch
@medusajs/file Patch
@medusajs/fulfillment Patch
@medusajs/index Patch
@medusajs/inventory Patch
@medusajs/link-modules Patch
@medusajs/locking Patch
@medusajs/notification Patch
@medusajs/order Patch
@medusajs/payment Patch
@medusajs/pricing Patch
@medusajs/promotion Patch
@medusajs/region Patch
@medusajs/sales-channel Patch
@medusajs/settings Patch
@medusajs/stock-location Patch
@medusajs/store Patch
@medusajs/tax Patch
@medusajs/user Patch
@medusajs/workflow-engine-inmemory Patch
@medusajs/workflow-engine-redis Patch
@medusajs/draft-order Patch
@medusajs/oas-github-ci Patch
@medusajs/cache-inmemory Patch
@medusajs/cache-redis Patch
@medusajs/event-bus-local Patch
@medusajs/event-bus-redis Patch
@medusajs/analytics-local Patch
@medusajs/analytics-posthog Patch
@medusajs/auth-emailpass Patch
@medusajs/auth-github Patch
@medusajs/auth-google Patch
@medusajs/caching-redis Patch
@medusajs/file-local Patch
@medusajs/file-s3 Patch
@medusajs/fulfillment-manual Patch
@medusajs/locking-postgres Patch
@medusajs/locking-redis Patch
@medusajs/notification-local Patch
@medusajs/notification-sendgrid Patch
@medusajs/payment-stripe Patch
@medusajs/core-flows Patch
@medusajs/framework Patch
@medusajs/js-sdk Patch
@medusajs/modules-sdk Patch
@medusajs/orchestration Patch
@medusajs/types Patch
@medusajs/utils Patch
@medusajs/workflows-sdk Patch
@medusajs/cli Patch
@medusajs/deps Patch
@medusajs/telemetry Patch
@medusajs/admin-bundler Patch
@medusajs/admin-sdk Patch
@medusajs/admin-shared Patch
@medusajs/admin-vite-plugin Patch
@medusajs/dashboard Patch
@medusajs/icons Patch
@medusajs/toolbox Patch
@medusajs/ui-preset Patch
create-medusa-app Patch
medusa-dev-cli Patch
@medusajs/ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link
Copy Markdown

vercel bot commented Oct 10, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

8 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
api-reference Ignored Ignored Oct 28, 2025 9:18am
api-reference-v2 Ignored Ignored Preview Oct 28, 2025 9:18am
cloud-docs Ignored Ignored Preview Oct 28, 2025 9:18am
docs-ui Ignored Ignored Preview Oct 28, 2025 9:18am
docs-v2 Ignored Ignored Preview Oct 28, 2025 9:18am
medusa-docs Ignored Ignored Preview Oct 28, 2025 9:18am
resources-docs Ignored Ignored Preview Oct 28, 2025 9:18am
user-guide Ignored Ignored Preview Oct 28, 2025 9:18am


for (const image of variantImages) {
if (variantImageIds.includes(image.id)) {
variant.images.push(image)
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self-review: should we return just an array of ids

@fPolic fPolic force-pushed the feat/scoped-variant-images--product-fetch branch from c61f8e7 to 69c65c4 Compare October 23, 2025 07:30
Base automatically changed from feat/scoped-variant-images to develop October 26, 2025 14:15
@olivermrbl
Copy link
Copy Markdown
Contributor

@fPolic could I get you to resolve the conflicts here, so we can get the branch up to speed with the recent merged?

@fPolic fPolic force-pushed the feat/scoped-variant-images--product-fetch branch from 69c65c4 to 697a88e Compare October 27, 2025 08:10
@fPolic
Copy link
Copy Markdown
Contributor Author

fPolic commented Oct 27, 2025

@olivermrbl done!

@kodiakhq kodiakhq bot merged commit 0b202cc into develop Oct 28, 2025
29 checks passed
@kodiakhq kodiakhq bot deleted the feat/scoped-variant-images--product-fetch branch October 28, 2025 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants