feat(product): build variant images when retrieving product#13731
Merged
kodiakhq[bot] merged 6 commits intodevelopfrom Oct 28, 2025
Merged
feat(product): build variant images when retrieving product#13731kodiakhq[bot] merged 6 commits intodevelopfrom
kodiakhq[bot] merged 6 commits intodevelopfrom
Conversation
🦋 Changeset detectedLatest commit: f1f3dd0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 74 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub. 8 Skipped Deployments
|
fPolic
commented
Oct 10, 2025
packages/modules/product/src/services/product-module-service.ts
Outdated
Show resolved
Hide resolved
fPolic
commented
Oct 10, 2025
|
|
||
| for (const image of variantImages) { | ||
| if (variantImageIds.includes(image.id)) { | ||
| variant.images.push(image) |
Contributor
Author
There was a problem hiding this comment.
self-review: should we return just an array of ids
This was referenced Oct 10, 2025
c61f8e7 to
69c65c4
Compare
Contributor
|
@fPolic could I get you to resolve the conflicts here, so we can get the branch up to speed with the recent merged? |
69c65c4 to
697a88e
Compare
Contributor
Author
|
@olivermrbl done! |
adrien2p
approved these changes
Oct 27, 2025
packages/modules/product/src/services/product-module-service.ts
Outdated
Show resolved
Hide resolved
packages/modules/product/src/services/product-module-service.ts
Outdated
Show resolved
Hide resolved
packages/modules/product/src/services/product-module-service.ts
Outdated
Show resolved
Hide resolved
This was referenced Oct 28, 2025
Merged
This was referenced Oct 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What