feat(order,dashboard): version order credit lines#13766
Merged
olivermrbl merged 10 commits intodevelopfrom Oct 22, 2025
Merged
Conversation
🦋 Changeset detectedLatest commit: e4531e0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 74 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
7 Skipped Deployments
|
willbouch
changed the title
olivermrbl
approved these changes
Oct 19, 2025
Contributor
olivermrbl
left a comment
olivermrbl
left a comment
There was a problem hiding this comment.
LGTM, I guess we could add a test for this, but since we are following an existing pattern, it's not critical. Will let you decide
Contributor
Author
Will take a look |
fPolic
approved these changes
Oct 21, 2025
| amount: model.bigNumber(), | ||
| raw_amount: model.json(), | ||
| metadata: model.json().nullable(), | ||
| order: model.belongsTo<() => typeof Order>(() => Order, { |
Contributor
There was a problem hiding this comment.
nit: isn't the type inferred here?
Contributor
Author
There was a problem hiding this comment.
Yes, you are absolutely right. That's what happens when you let Claude do too much haha
This was referenced Oct 21, 2025
Merged
This was referenced Oct 22, 2025
Merged
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
What — What changes are introduced in this PR?
Added
versionto the already credit line entityWhy — Why are these changes relevant or necessary?
When issuing an Ad Hoc refund, we systematically create a credit line of the same value to balance out the order total. However, if something goes wrong in the workflow, there was no way to really revert the edits to the order because credit lines did not have version.
Testing — How have these changes been tested, or how can the reviewer test the feature?
The revert flow is pretty thoroughly tested I noticed so I mostly tested manually. I confirmed that before, the credit lines were not reverted in case of an error and now it does.
Checklist
Please ensure the following before requesting a review:
yarn changesetand follow the promptsCLOSES CORE-1248