feat(core-flows,order,medusa,types): allow to update the original order.email on order customer transfer requests by NicolasGorga · Pull Request #14234 · medusajs/medusa

NicolasGorga · 2025-12-07T04:50:47Z

Summary

What — What changes are introduced in this PR?

Update order.email upon customer transfer acceptance.

Why — Why are these changes relevant or necessary?

To prevent the order from retaining a link to the old customer email and align it to it's customer relation after the transfer is accepted.

How — How have these changes been implemented?

When processing the transfer customer action operation set the order.email property.

Testing — How have these changes been tested, or how can the reviewer test the feature?

Integration tests.

Examples

Provide examples or code snippets that demonstrate how this feature works, or how it can be used in practice.
This helps with documentation and ensures maintainers can quickly understand and verify the change.

// Example usage

Checklist

Please ensure the following before requesting a review:

I have added a changeset for this PR
- Every non-breaking change should be marked as a patch
- To add a changeset, run yarn changeset and follow the prompts
The changes are covered by relevant tests
I have verified the code works as intended locally
I have linked the related issue(s) if applicable

Additional Context

Add any additional context, related issues, or references that might help the reviewer understand this PR.

fixes #14161

vercel · 2025-12-07T04:50:52Z

The latest updates on your projects. Learn more about Vercel for GitHub.

9 Skipped Deployments

Project	Deployment	Actions	Updated (UTC)
api-reference	Ignored		Apr 9, 2026 4:35pm
api-reference-v2	Ignored	Preview	Apr 9, 2026 4:35pm
bloom-docs	Ignored	Preview	Apr 9, 2026 4:35pm
cloud-docs	Ignored	Preview	Apr 9, 2026 4:35pm
docs-ui	Ignored	Preview	Apr 9, 2026 4:35pm
docs-v2	Ignored	Preview	Apr 9, 2026 4:35pm
medusa-docs	Ignored	Preview	Apr 9, 2026 4:35pm
resources-docs	Ignored	Preview	Apr 9, 2026 4:35pm
user-guide	Ignored	Preview	Apr 9, 2026 4:35pm

changeset-bot · 2025-12-07T04:50:53Z

🦋 Changeset detected

Latest commit: bc446b1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 77 packages

Name	Type
@medusajs/core-flows	Patch
@medusajs/order	Patch
@medusajs/medusa	Patch
@medusajs/test-utils	Patch
integration-tests-http	Patch
@medusajs/medusa-oas-cli	Patch
@medusajs/analytics	Patch
@medusajs/api-key	Patch
@medusajs/auth	Patch
@medusajs/caching	Patch
@medusajs/cart	Patch
@medusajs/currency	Patch
@medusajs/customer	Patch
@medusajs/file	Patch
@medusajs/fulfillment	Patch
@medusajs/index	Patch
@medusajs/inventory	Patch
@medusajs/link-modules	Patch
@medusajs/locking	Patch
@medusajs/notification	Patch
@medusajs/payment	Patch
@medusajs/pricing	Patch
@medusajs/product	Patch
@medusajs/promotion	Patch
@medusajs/rbac	Patch
@medusajs/region	Patch
@medusajs/sales-channel	Patch
@medusajs/settings	Patch
@medusajs/stock-location	Patch
@medusajs/store	Patch
@medusajs/tax	Patch
@medusajs/translation	Patch
@medusajs/user	Patch
@medusajs/workflow-engine-inmemory	Patch
@medusajs/workflow-engine-redis	Patch
@medusajs/draft-order	Patch
@medusajs/oas-github-ci	Patch
@medusajs/cache-inmemory	Patch
@medusajs/cache-redis	Patch
@medusajs/event-bus-local	Patch
@medusajs/event-bus-redis	Patch
@medusajs/analytics-local	Patch
@medusajs/analytics-posthog	Patch
@medusajs/auth-emailpass	Patch
@medusajs/auth-github	Patch
@medusajs/auth-google	Patch
@medusajs/caching-redis	Patch
@medusajs/file-local	Patch
@medusajs/file-s3	Patch
@medusajs/fulfillment-manual	Patch
@medusajs/locking-postgres	Patch
@medusajs/locking-redis	Patch
@medusajs/notification-local	Patch
@medusajs/notification-sendgrid	Patch
@medusajs/payment-stripe	Patch
@medusajs/framework	Patch
@medusajs/js-sdk	Patch
@medusajs/modules-sdk	Patch
@medusajs/orchestration	Patch
@medusajs/types	Patch
@medusajs/utils	Patch
@medusajs/workflows-sdk	Patch
@medusajs/http-types-generator	Patch
@medusajs/cli	Patch
@medusajs/deps	Patch
@medusajs/telemetry	Patch
@medusajs/admin-bundler	Patch
@medusajs/admin-sdk	Patch
@medusajs/admin-shared	Patch
@medusajs/admin-vite-plugin	Patch
@medusajs/dashboard	Patch
@medusajs/icons	Patch
@medusajs/toolbox	Patch
@medusajs/ui-preset	Patch
create-medusa-app	Patch
medusa-dev-cli	Patch
@medusajs/ui	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

olivermrbl

thought: based on the comments in the code, keeping the original email seemed to have been a very intentional action. I can't remember why, but maybe @fPolic can pitch in

fPolic · 2025-12-08T09:12:56Z

keeping the original email seemed to have been a very intentional action

I think we wanted to keep email associated with the order in case purchase was intentionally made with that email and the email needs to be associated with the purchased good.

This seems to be an issue when doing transfers between registered accounts (while the original idea behind this feature was to allow claiming an order from unregisterd -> registered account).
However, solution could be for users to implement this when sending the request email as described in the issue:

// send confirmation to this email in subscriber
const emailToConfirmTransfer = order.customer?.email ?? order.email

if customer is an unregistered account, we will have the same behaviour and the email will be sent to order.email
if customer is registered account, email will be send to the current registered owner

NicolasGorga · 2025-12-08T11:49:57Z

keeping the original email seemed to have been a very intentional action

I think we wanted to keep email associated with the order in case purchase was intentionally made with that email and the email needs to be associated with the purchased good.

This seems to be an issue when doing transfers between registered accounts (while the original idea behind this feature was to allow claiming an order from unregisterd -> registered account). However, solution could be for users to implement this when sending the request email as described in the issue:
// send confirmation to this email in subscriber
const emailToConfirmTransfer = order.customer?.email ?? order.email
if customer is an unregistered account, we will have the same behaviour and the email will be sent to order.email

if customer is registered account, email will be send to the current registered owner

But I think not the majority of the cases would need this: I think we wanted to keep email associated with the order in case purchase was intentionally made with that email and the email needs to be associated with the purchased good. so it would confuse the ones that don't need these. The few cases that need this, would be able to still retrieve the original customer's email through the first order change action type TRANSFER_CUSTOMER no?

NicolasGorga · 2025-12-11T12:46:24Z

Let me know what you think of my last comment guys @fPolic @olivermrbl

adrien2p · 2025-12-12T09:09:44Z

packages/modules/order/src/services/order-module-service.ts

      orderId,
      {
-        select: ["id", "version", "items.detail", "summary", "total"],
+        select: ["id", "version", "items.detail", "summary", "total", "email"],


Q: wondering if it would have any side effect to rely on the orderService_ instead of retrieve (same for retrieveOrderChange) which serialize their result upon returning 🤔

github-actions · 2026-01-13T02:12:22Z

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions · 2026-01-18T02:12:52Z

This PR was closed because it has been stalled for 5 days with no activity.

github-actions · 2026-03-04T02:13:12Z

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions · 2026-03-12T02:13:22Z

This PR was closed because it has been stalled for 5 days with no activity.

medusa-os-bot · 2026-04-09T09:27:54Z

Thank you for your contribution!

After an initial review, this PR looks good to us. Here's a summary:

✅ Linked to a verified issue
✅ Changeset included with correct format
✅ Integration tests updated

Notes:

There is an open design discussion from @fPolic in the comments (December 2025) questioning whether updating order.email on transfer acceptance was intentional — the original behaviour was to keep the email tied to the purchase. The PR was stale-closed twice before being reopened, so it seems this has not been resolved. A team member should confirm alignment on the intended behaviour before merging.

Additionally, email is already present in orderEditableAttributes in the current develop state of apply-order-changes.ts. The +1 line added to that file in this PR should be double-checked to ensure it doesn't produce a duplicate entry.

A team member will do a final review before this is merged. We appreciate your patience!

…n the workflow, to transfer the original order.email conditionally

NicolasGorga added 3 commits December 7, 2025 01:38

Update order email on customer transfer

b52fab4

Tests

3004d60

Add changeset

1aae673

NicolasGorga requested a review from a team as a code owner December 7, 2025 04:50

github-actions bot added type: bug team: medusa labels Dec 7, 2025

olivermrbl reviewed Dec 8, 2025

View reviewed changes

adrien2p approved these changes Dec 12, 2025

View reviewed changes

github-actions bot added the Stale label Jan 13, 2026

github-actions bot closed this Jan 18, 2026

NicolasGorga reopened this Jan 18, 2026

github-actions bot removed the Stale label Jan 20, 2026

NicolasGorga requested a review from fPolic January 30, 2026 15:50

github-actions bot added the Stale label Mar 4, 2026

github-actions bot closed this Mar 12, 2026

NicolasGorga reopened this Mar 23, 2026

github-actions bot removed the Stale label Mar 26, 2026

medusa-os-bot bot added the initial-approval label Apr 9, 2026

shahednasser and others added 2 commits April 9, 2026 14:13

Merge branch 'develop' into fix/order-email-customer-transfer

2cf2cf3

Make the feature backwards compatible, by accepting a new parameter i…

fd9e270

…n the workflow, to transfer the original order.email conditionally

Update changeset

bc446b1

NicolasGorga changed the title ~~fix(core-flows,order): update order.email on accepted customer transfer~~ feat(core-flows,order,medusa,types): allow to update the original order.email on order customer transfer requests Apr 9, 2026

shahednasser approved these changes Apr 10, 2026

View reviewed changes

shahednasser merged commit 2045c77 into develop Apr 10, 2026
45 of 46 checks passed

shahednasser deleted the fix/order-email-customer-transfer branch April 10, 2026 06:02

Uh oh!

Conversation

NicolasGorga commented Dec 7, 2025

Summary

Examples

Checklist

Additional Context

Uh oh!

vercel bot commented Dec 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Dec 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

olivermrbl left a comment

Choose a reason for hiding this comment

Uh oh!

fPolic commented Dec 8, 2025

Uh oh!

NicolasGorga commented Dec 8, 2025

Uh oh!

NicolasGorga commented Dec 11, 2025

Uh oh!

adrien2p Dec 12, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jan 13, 2026

Uh oh!

github-actions bot commented Jan 18, 2026

Uh oh!

github-actions bot commented Mar 4, 2026

Uh oh!

github-actions bot commented Mar 12, 2026

Uh oh!

medusa-os-bot bot commented Apr 9, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

vercel bot commented Dec 7, 2025 •

edited

Loading

changeset-bot bot commented Dec 7, 2025 •

edited

Loading