Skip to content

feat(core-flows,order,medusa,types): Version shipping method adjustments & implement missing creation flow for versioned adjustments#14482

Merged
shahednasser merged 30 commits intodevelopfrom
feat/version-order-shipping-method-adjustments
Apr 10, 2026
Merged

feat(core-flows,order,medusa,types): Version shipping method adjustments & implement missing creation flow for versioned adjustments#14482
shahednasser merged 30 commits intodevelopfrom
feat/version-order-shipping-method-adjustments

Conversation

@NicolasGorga
Copy link
Copy Markdown
Contributor

@NicolasGorga NicolasGorga commented Jan 7, 2026

Summary

What — What changes are introduced in this PR?

Add version to shipping method adjustments and implement the missing flow for versioned creation of both line and shipping method adjustments.

Why — Why are these changes relevant or necessary?

Adjustments don't align with the versioned nature of order related entities.

How — How have these changes been implemented?

Added the version field to shipping method adjustments and handle their versions when applying order changes. Implemented missing logic to actually create/delete the versioned line/shipping methods adjustments.

Testing — How have these changes been tested, or how can the reviewer test the feature?

Tests.


Examples

Provide examples or code snippets that demonstrate how this feature works, or how it can be used in practice.
This helps with documentation and ensures maintainers can quickly understand and verify the change.

// Example usage

Checklist

Please ensure the following before requesting a review:

  • I have added a changeset for this PR
    • Every non-breaking change should be marked as a patch
    • To add a changeset, run yarn changeset and follow the prompts
  • The changes are covered by relevant tests
  • I have verified the code works as intended locally
  • I have linked the related issue(s) if applicable

Additional Context

Add any additional context, related issues, or references that might help the reviewer understand this PR.

fixes #14384, CORE-1359

@NicolasGorga NicolasGorga requested review from a team as code owners January 7, 2026 20:07
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Jan 7, 2026

🦋 Changeset detected

Latest commit: 5610b41

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 77 packages
Name Type
@medusajs/core-flows Patch
@medusajs/order Patch
@medusajs/types Patch
@medusajs/medusa Patch
@medusajs/test-utils Patch
integration-tests-http Patch
@medusajs/event-bus-redis Patch
@medusajs/draft-order Patch
@medusajs/framework Patch
@medusajs/js-sdk Patch
@medusajs/modules-sdk Patch
@medusajs/orchestration Patch
@medusajs/utils Patch
@medusajs/workflows-sdk Patch
@medusajs/medusa-oas-cli Patch
@medusajs/admin-bundler Patch
@medusajs/dashboard Patch
@medusajs/analytics Patch
@medusajs/api-key Patch
@medusajs/auth Patch
@medusajs/caching Patch
@medusajs/cart Patch
@medusajs/currency Patch
@medusajs/customer Patch
@medusajs/file Patch
@medusajs/fulfillment Patch
@medusajs/index Patch
@medusajs/inventory Patch
@medusajs/link-modules Patch
@medusajs/locking Patch
@medusajs/notification Patch
@medusajs/payment Patch
@medusajs/pricing Patch
@medusajs/product Patch
@medusajs/promotion Patch
@medusajs/rbac Patch
@medusajs/region Patch
@medusajs/sales-channel Patch
@medusajs/settings Patch
@medusajs/stock-location Patch
@medusajs/store Patch
@medusajs/tax Patch
@medusajs/translation Patch
@medusajs/user Patch
@medusajs/workflow-engine-inmemory Patch
@medusajs/workflow-engine-redis Patch
@medusajs/cache-inmemory Patch
@medusajs/cache-redis Patch
@medusajs/event-bus-local Patch
@medusajs/analytics-local Patch
@medusajs/analytics-posthog Patch
@medusajs/auth-emailpass Patch
@medusajs/auth-github Patch
@medusajs/auth-google Patch
@medusajs/caching-redis Patch
@medusajs/file-local Patch
@medusajs/file-s3 Patch
@medusajs/fulfillment-manual Patch
@medusajs/locking-postgres Patch
@medusajs/locking-redis Patch
@medusajs/notification-local Patch
@medusajs/notification-sendgrid Patch
@medusajs/payment-stripe Patch
@medusajs/oas-github-ci Patch
@medusajs/http-types-generator Patch
@medusajs/cli Patch
@medusajs/deps Patch
@medusajs/telemetry Patch
@medusajs/admin-sdk Patch
@medusajs/admin-shared Patch
@medusajs/admin-vite-plugin Patch
@medusajs/icons Patch
@medusajs/toolbox Patch
@medusajs/ui-preset Patch
create-medusa-app Patch
medusa-dev-cli Patch
@medusajs/ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link
Copy Markdown

vercel bot commented Jan 7, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

9 Skipped Deployments
Project Deployment Actions Updated (UTC)
api-reference Ignored Ignored Apr 9, 2026 5:01pm
api-reference-v2 Ignored Ignored Preview Apr 9, 2026 5:01pm
bloom-docs Ignored Ignored Preview Apr 9, 2026 5:01pm
cloud-docs Ignored Ignored Preview Apr 9, 2026 5:01pm
docs-ui Ignored Ignored Preview Apr 9, 2026 5:01pm
docs-v2 Ignored Ignored Preview Apr 9, 2026 5:01pm
medusa-docs Ignored Ignored Preview Apr 9, 2026 5:01pm
resources-docs Ignored Ignored Preview Apr 9, 2026 5:01pm
user-guide Ignored Ignored Preview Apr 9, 2026 5:01pm

Request Review

@NicolasGorga NicolasGorga changed the title fix(core-flows): Pass shipping_methods to computeActions context feat(core-flows,order,medusa,types): Version shipping method adjustments & implement missing creation flow for versioned adjustments Jan 7, 2026
@NicolasGorga
Copy link
Copy Markdown
Contributor Author

@adrien2p the migration i included to add unique index on order_line_item_adjustment would make this a breaking change I guess. The correct thing is to add it, but it makes me think of the recent situation where we did this for order_item and it caused issues for customers with existing duplication in their DBs (cc @olivermrbl )

@cursor
Copy link
Copy Markdown

cursor bot commented Jan 18, 2026

You have run out of free Bugbot PR reviews for this billing cycle. This will reset on February 17.

To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 7, 2026

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Mar 7, 2026
@github-actions
Copy link
Copy Markdown
Contributor

This PR was closed because it has been stalled for 5 days with no activity.

@github-actions github-actions bot closed this Mar 12, 2026
@NicolasGorga NicolasGorga reopened this Mar 23, 2026
@medusa-os-bot
Copy link
Copy Markdown

medusa-os-bot bot commented Apr 9, 2026

After an initial review, this PR looks good to us. Here's a summary:

✅ Linked to verified bug #14384
✅ Follows the established ITEM_ADJUSTMENTS_REPLACE pattern for shipping methods
✅ Tests included (HTTP integration tests + module integration tests)
✅ Changeset files present

A team member will do a final review before this is merged.


Notes:

  • Migration unique index — The discussion from January 8 flagged that the migration may add a unique index on order_line_item_adjustment, which could fail for existing users with duplicate data (similar to the issue seen with order_item). Please confirm whether this was addressed in Migration20260106185528.ts (e.g., unique index removed, or a deduplication step added before the index).

  • Planning documentthoughts/shared/plans/2026-01-06-order-adjustment-versioning.md (965 lines) is committed alongside the code changes. Confirm this is intentional and should be included in the merge, or remove it before the final review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: revertLastVersion does not clean up OrderLineItemAdjustment, OrderShippingMethodAdjustment, and tax line records during workflow rollback

4 participants