Skip to content

feat(core-flows,order,medusa,types): update item metadata on item_update change action#14570

Merged
kodiakhq[bot] merged 18 commits intodevelopfrom
feat/metadata-item-update-order-change
Apr 10, 2026
Merged

feat(core-flows,order,medusa,types): update item metadata on item_update change action#14570
kodiakhq[bot] merged 18 commits intodevelopfrom
feat/metadata-item-update-order-change

Conversation

@NicolasGorga
Copy link
Copy Markdown
Contributor

@NicolasGorga NicolasGorga commented Jan 18, 2026

Summary

What — What changes are introduced in this PR?

Allow to update item metadata on ITEM_UPDATE order change action.

Why — Why are these changes relevant or necessary?

You are unable to update a draft order item metadata.

How — How have these changes been implemented?

Update item metadata if specified in the order change action details when the ITEM_UPDATE processing handler gets executed.

Testing — How have these changes been tested, or how can the reviewer test the feature?

Integration tests.


Examples

Provide examples or code snippets that demonstrate how this feature works, or how it can be used in practice.
This helps with documentation and ensures maintainers can quickly understand and verify the change.

// Example usage

Checklist

Please ensure the following before requesting a review:

  • I have added a changeset for this PR
    • Every non-breaking change should be marked as a patch
    • To add a changeset, run yarn changeset and follow the prompts
  • The changes are covered by relevant tests
  • I have verified the code works as intended locally
  • I have linked the related issue(s) if applicable

Additional Context

Add any additional context, related issues, or references that might help the reviewer understand this PR.

closes #14481


Note

Adds support for updating item metadata during draft order item updates.

  • Core flow update-draft-order-item now includes metadata in action details for ITEM_UPDATE
  • Order processing merges provided metadata into both item.detail.metadata and item.metadata
  • Types expanded to include optional metadata for new/existing items and related inputs
  • Admin validators allow metadata in draft order item update payloads
  • Order transform maps detail.metadata to exposed item metadata
  • Integration test added to verify metadata update behavior

Written by Cursor Bugbot for commit 350a79e. This will update automatically on new commits. Configure here.

@NicolasGorga NicolasGorga requested a review from a team as a code owner January 18, 2026 00:40
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Jan 18, 2026

🦋 Changeset detected

Latest commit: a6aa456

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 77 packages
Name Type
@medusajs/core-flows Patch
@medusajs/order Patch
@medusajs/types Patch
@medusajs/medusa Patch
@medusajs/test-utils Patch
integration-tests-http Patch
@medusajs/event-bus-redis Patch
@medusajs/draft-order Patch
@medusajs/framework Patch
@medusajs/js-sdk Patch
@medusajs/modules-sdk Patch
@medusajs/orchestration Patch
@medusajs/utils Patch
@medusajs/workflows-sdk Patch
@medusajs/medusa-oas-cli Patch
@medusajs/admin-bundler Patch
@medusajs/dashboard Patch
@medusajs/analytics Patch
@medusajs/api-key Patch
@medusajs/auth Patch
@medusajs/caching Patch
@medusajs/cart Patch
@medusajs/currency Patch
@medusajs/customer Patch
@medusajs/file Patch
@medusajs/fulfillment Patch
@medusajs/index Patch
@medusajs/inventory Patch
@medusajs/link-modules Patch
@medusajs/locking Patch
@medusajs/notification Patch
@medusajs/payment Patch
@medusajs/pricing Patch
@medusajs/product Patch
@medusajs/promotion Patch
@medusajs/rbac Patch
@medusajs/region Patch
@medusajs/sales-channel Patch
@medusajs/settings Patch
@medusajs/stock-location Patch
@medusajs/store Patch
@medusajs/tax Patch
@medusajs/translation Patch
@medusajs/user Patch
@medusajs/workflow-engine-inmemory Patch
@medusajs/workflow-engine-redis Patch
@medusajs/cache-inmemory Patch
@medusajs/cache-redis Patch
@medusajs/event-bus-local Patch
@medusajs/analytics-local Patch
@medusajs/analytics-posthog Patch
@medusajs/auth-emailpass Patch
@medusajs/auth-github Patch
@medusajs/auth-google Patch
@medusajs/caching-redis Patch
@medusajs/file-local Patch
@medusajs/file-s3 Patch
@medusajs/fulfillment-manual Patch
@medusajs/locking-postgres Patch
@medusajs/locking-redis Patch
@medusajs/notification-local Patch
@medusajs/notification-sendgrid Patch
@medusajs/payment-stripe Patch
@medusajs/oas-github-ci Patch
@medusajs/http-types-generator Patch
@medusajs/cli Patch
@medusajs/deps Patch
@medusajs/telemetry Patch
@medusajs/admin-sdk Patch
@medusajs/admin-shared Patch
@medusajs/admin-vite-plugin Patch
@medusajs/icons Patch
@medusajs/toolbox Patch
@medusajs/ui-preset Patch
create-medusa-app Patch
medusa-dev-cli Patch
@medusajs/ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link
Copy Markdown

vercel bot commented Jan 18, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

9 Skipped Deployments
Project Deployment Actions Updated (UTC)
api-reference Ignored Ignored Apr 10, 2026 9:19pm
api-reference-v2 Ignored Ignored Preview Apr 10, 2026 9:19pm
bloom-docs Ignored Ignored Preview Apr 10, 2026 9:19pm
cloud-docs Ignored Ignored Preview Apr 10, 2026 9:19pm
docs-ui Ignored Ignored Preview Apr 10, 2026 9:19pm
docs-v2 Ignored Ignored Preview Apr 10, 2026 9:19pm
medusa-docs Ignored Ignored Preview Apr 10, 2026 9:19pm
resources-docs Ignored Ignored Preview Apr 10, 2026 9:19pm
user-guide Ignored Ignored Preview Apr 10, 2026 9:19pm

Request Review

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

@NicolasGorga NicolasGorga requested a review from adrien2p January 23, 2026 18:17
Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

@github-actions
Copy link
Copy Markdown
Contributor

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Feb 28, 2026
@medusa-os-bot
Copy link
Copy Markdown

medusa-os-bot bot commented Apr 9, 2026

Thank you for your contribution! 🎉

After an initial review, this PR looks good to us. Here's a summary:

✅ Linked to a verified issue (#14481)
✅ Changeset included
✅ Integration tests included
✅ Follows Medusa's conventions

A team member will do a final review before this is merged. We appreciate your patience!


Notes:

Adding metadata to the ExistingItem interface also affects OrderEditUpdateItemQuantityWorkflowInput, which is shared with the order-edit-update-item-quantity workflow (regular order edits). That workflow's transform does not include metadata in the action details it builds:

// packages/core/core-flows/src/order/workflows/order-edit/order-edit-update-item-quantity.ts
details: {
  reference_id: item.id,
  quantity: item.quantity,
  unit_price: item.unit_price,
  compare_at_unit_price: item.compare_at_unit_price,
  quantity_diff: quantityDiff,
  // metadata is accepted by the type but silently dropped here
},

This means a caller using order-edit-update-item-quantity and passing metadata on items would have it silently discarded. Worth deciding whether to also update that workflow for consistency, or use a narrower type scoped to the draft order context.

@NicolasGorga NicolasGorga requested review from shahednasser and removed request for adrien2p and carlos-r-l-rodrigues April 9, 2026 21:18
@kodiakhq kodiakhq bot merged commit 9e1e708 into develop Apr 10, 2026
42 checks passed
@kodiakhq kodiakhq bot deleted the feat/metadata-item-update-order-change branch April 10, 2026 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Cannot Update Items metadata in draft order

3 participants