fix(admin): handle null sales channel references in product list and detail views

.changeset/fix-orphaned-sales-channel.md

@@ -0,0 +1,5 @@
+---
+"@medusajs/dashboard": patch
+---
+
+fix(admin): handle null sales channel references in product list and detail views

packages/admin/dashboard/src/components/table/table-cells/product/sales-channels-cell/sales-channels-cell.tsx

@@ -13,39 +13,45 @@ export const SalesChannelsCell = ({
 }: SalesChannelsCellProps) => {
   const { t } = useTranslation()
 
-  if (!salesChannels || !salesChannels.length) {
+  // Filter out null/undefined entries that can occur when a sales channel
+  // is deleted but the product association is not cleaned up
+  const validChannels = salesChannels?.filter(
+    (sc): sc is SalesChannelDTO => sc != null
+  )
+
+  if (!validChannels || !validChannels.length) {
     return <PlaceholderCell />
   }
 
-  if (salesChannels.length > 2) {
+  if (validChannels.length > 2) {
     return (
       <div className="flex h-full w-full items-center gap-x-1 overflow-hidden">
         <span className="truncate">
-          {salesChannels
+          {validChannels
             .slice(0, 2)
             .map((sc) => sc.name)
             .join(", ")}
         </span>
         <Tooltip
           content={
             <ul>
-              {salesChannels.slice(2).map((sc) => (
+              {validChannels.slice(2).map((sc) => (
                 <li key={sc.id}>{sc.name}</li>
               ))}
             </ul>
           }
         >
           <span className="text-xs">
             {t("general.plusCountMore", {
-              count: salesChannels.length - 2,
+              count: validChannels.length - 2,
             })}
           </span>
         </Tooltip>
       </div>
     )
   }
 
-  const channels = salesChannels.map((sc) => sc.name).join(", ")
+  const channels = validChannels.map((sc) => sc.name).join(", ")
 
   return (
     <div className="flex h-full w-full items-center overflow-hidden max-w-[250px]">

packages/admin/dashboard/src/routes/products/product-detail/components/product-sales-channel-section/product-sales-channel-section.tsx

@@ -16,11 +16,15 @@ export const ProductSalesChannelSection = ({
   const { count } = useSalesChannels()
   const { t } = useTranslation()
 
+  // Filter out null/undefined entries that can occur when a sales channel
+  // is deleted but the product association is not cleaned up
   const availableInSalesChannels =
-    product.sales_channels?.map((sc) => ({
-      id: sc.id,
-      name: sc.name,
-    })) ?? []
+    product.sales_channels
+      ?.filter((sc) => sc != null)
+      .map((sc) => ({
+        id: sc.id,
+        name: sc.name,
+      })) ?? []
 
   const firstChannels = availableInSalesChannels.slice(0, 3)
   const restChannels = availableInSalesChannels.slice(3)