Increase connection.wbuf size from 64k to 1m#16
Open
thatsafunnyname wants to merge 2 commits intomemcached:masterfrom
Open
Increase connection.wbuf size from 64k to 1m#16thatsafunnyname wants to merge 2 commits intomemcached:masterfrom
thatsafunnyname wants to merge 2 commits intomemcached:masterfrom
Conversation
This is to support setting keys with value_size 1047552 (1023k) as done in conf/set_big_values. memcached#10
Member
|
Thanks! This does make it use way too much memory for high connection count tests though. Since that wbuf is at the end of the connection structure it could be turned into a dynamic array and sized via a start parameter. Don't think I can accept the simple patch due to the memory issue though. Would you be up to trying that out? Also for what it's worth I've personally moved on to mcshredder now: https://github.com/memcached/mcshredder - though it doesn't have enough useful docs or example scripts to get people going. |
connection.wbuf is changed from a static sized array on the stack to a pointer to a dynamically sized heap allocation. So that configs with many connections do not over allocate memory for wbuf, while also now supporting value_size > 64k
Author
|
I changed it to a dynamic array. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to support setting keys with value_size 1047552 (1023k) as done in conf/set_big_values.
#10